Giter Club home page Giter Club logo

Comments (7)

gfursin avatar gfursin commented on August 13, 2024 1

Sure. Thanks for noting the issue! Then the CM project should be fine but we keep CK archived for now. I will close this issue!

from ck.

gfursin avatar gfursin commented on August 13, 2024

Hi

Thank you for noting that @abravalheri!

The CK framework is archived and we do not update it unless requested by users, but this deprecation influence our new CM framework here.

Do you know if there is an alternative from distutils? Should I do something like this code to import it (while keeping backward compatibility for older systems with setuptools)?

Thank you!

from ck.

abravalheri avatar abravalheri commented on August 13, 2024

Do you know if there is an alternative from distutils? Should I do something like this code to import it (while keeping backward compatibility for older systems with setuptools)?

Hi @gfursin, I find that convert_path is usually not essential for implementing the common functionality.

This is the description of the function:

   """Return 'pathname' as a name that will work on the native filesystem,
   i.e. split it on '/' and put it back together again using the current
   directory separator.  Needed because filenames in the setup script are
   always supplied in Unix style, and have to be converted to the local
   convention before we can actually use them in the filesystem.  Raises
   ValueError on non-Unix-ish systems if 'pathname' either starts or
   ends with a slash.
   """

But most of the Python functions nowadays already allow you to use / for paths even on windows...

Other than that, the function also raises an error if the path is absolute or if it ends in /, but that is easily implementable with os.path.isabs and str.rstrip if needed... Finally, if normalisation is needed you can go with os.path.normpath.

from ck.

abravalheri avatar abravalheri commented on August 13, 2024

I see that in this particular setup.py what is being used is something like:

long_description=open(convert_path('./README.md'),
                          encoding="utf-8").read(),

which probably will work just fine if you replace
convert_path('./README.md') => "README.md"

from ck.

gfursin avatar gfursin commented on August 13, 2024

Cool! Thank you for the update. Let me check it this week!

from ck.

gfursin avatar gfursin commented on August 13, 2024

I removed convert_path from the CM framework.

Are you using CK framework? If not, I prefer not to touch it until it really fails in the future ;) ...

from ck.

abravalheri avatar abravalheri commented on August 13, 2024

Hi @gfursin, thank you for taking a look on this.

No, I am not working with CK. I am working on removing deprecated parts from setuptools.

from ck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.