Giter Club home page Giter Club logo

Comments (5)

NielsRogge avatar NielsRogge commented on June 11, 2024

@RobbeSneyders the evolve method should also include updating the metadata of the manifest (based on args.metadata). This is enough to get the updated locations right? As the locations are based on the metadata (run_id and component_id).

from fondant.

RobbeSneyders avatar RobbeSneyders commented on June 11, 2024

Yes they should be indeed. I'm not sure when the run_id and component_id will become available though. They might only be available at runtime.

from fondant.

NielsRogge avatar NielsRogge commented on June 11, 2024

The run_id is only available at run time, but the component_id is just the name of the component, which is also present in the component spec. (FondantComponentSpec).

from fondant.

RobbeSneyders avatar RobbeSneyders commented on June 11, 2024

Shouldn't the component_id also contain the version of the component (eg. the commit hash)? Unless this would be completely captured by the run_id.

from fondant.

NielsRogge avatar NielsRogge commented on June 11, 2024

Previously, the Manifest had a separate commit_hash key included in its metadata, besides the run_id, component_name.

from fondant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.