Deploy reloaded no longer working after vscode update to 1.59.0 about vscode-deploy-reloaded HOT 26 OPEN

I would like to offer an alternative solution instead of disabling MySQL features:

Cause:

Seems that there is a MySQL type definition in TypeScript 4.4, causing incorrect require binding, the type definition file is as follow:

Windows:
~/AppData/Local/Microsoft/TypeScript/4.4/node_modules/@types/mysql/index.d.ts
Mac:
~/Library/Caches/typescript/4.4/node_modules/@types/mysql/index.d.ts
Linux
~/.cache/typescript/4.4/node_modules/@types/mysql/index.d.ts

Change file:

Stable
~/.vscode/extensions/mkloubert.vscode-deploy-reloaded-0.89.0/out/sql/mysql.js
Insiders
~/.vscode-insiders/extensions/mkloubert.vscode-deploy-reloaded-0.89.0/out/sql/mysql.js
Remote Stable
~/.vscode-server/extensions/mkloubert.vscode-deploy-reloaded-0.89.0/out/sql/mysql.js
Remote Insiders
~/.vscode-server-insiders/extensions/mkloubert.vscode-deploy-reloaded-0.89.0/out/sql/mysql.js

Change code line 22:

From:
const MySQL = require("mysql");
To:
const MySQL = require("../../node_modules/mysql");

from vscode-deploy-reloaded.

I manage to bypass this issue by removing dependency of *sql and the functionality of running sql after deploy.
Made a release here. link

from vscode-deploy-reloaded.

As a workaround I have commented line 33 (const deploy_targets_operations_sql = require("./targets/operations/sql");) of file
(user_folder).vscode-server\extensions\kloubert.vscode-deploy-reloaded-0.89.0\out\targets.js in wsl2
(user_folder).vscode\extensions\kloubert.vscode-deploy-reloaded-0.89.0\out\targets.js

from vscode-deploy-reloaded.

@balbertho could do a pull request? Or @mkloubert to update this repo with these changes?

from vscode-deploy-reloaded.

I just experienced the same issue... The Deploy (Reloaded) extension stopped after VS Code updated to 1.59.0. In the Output window the plugin option for Deploy Reloaded is missing. Yikes!!! This is pretty critical to our workflow.

I also confirmed an uninstall and reinstall did not resolve the issue.

from vscode-deploy-reloaded.

@csears123 I'm not familiar with vscode extension develop. From the extension's wiki, sql is only used for operation after deployment. I simply commented out several file that provides sql connection, and a switch case that matches sql. And I also removed the dependency of mysql in package.json. You may check the tag attached with the release I linked above. After these modifications, sql cannot be used as post-deploy operations.
As for other occurrence of mysql in package.json, I guess these describes rules for editing vscode-deploy's setting. There's nothing to worry about them, but of course it's better to remove these too.

As for the backslash, I don't think it's the key cause, since I'm using macos that use / rather than \.

from vscode-deploy-reloaded.

Already tried an uninstall and reinstall

from vscode-deploy-reloaded.

I reverted to 1.58.2 until it's sorted out.

from vscode-deploy-reloaded.

I found this error in console.

Seems like broken dependency?

from vscode-deploy-reloaded.

@Jeffery-Song can you share more information on what you edited to remove the sql dependency? Are any features missing if this dependency is removed?

I am seeing the "mysql" module that is causing the "Cannot find module" error in my Log (Extension Host) output window. The package.json has over 130 objects that use "oneOf" mysql or sql.

[2021-08-06 08:13:29.580] [exthost] [error] Error: Cannot find module 'c:\Users{USER}.vscode\extensions\mkloubert.vscode-deploy-reloaded-0.89.0\node_modules\mysql/lib/Connection'
at t (c:\Users{USER}\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\microsoft-authentication\dist\extension.js:1:358851)
at Object.patch (c:\Users{USER}\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\microsoft-authentication\dist\extension.js:1:143340)
at Module.require (c:\Users{USER}\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\microsoft-authentication\dist\extension.js:1:39134)

I attempted to correct the path to use a Windows backslash "" (below) in the extension.js file, but that did not fix the error. It still cannot find the module. Permissions look find too for those files.

.vscode\extensions\mkloubert.vscode-deploy-reloaded-0.89.0\node_modules\mysql\lib\Connection

from vscode-deploy-reloaded.

I reverted to 1.58.2 until it's sorted out.

The last commit is from 2 years ago. Something tells me it's the end for this extension... It's sad, I used it a lot.

from vscode-deploy-reloaded.

@mkloubert could you please take a look at this?
seems like a critical issue.
Thanks!

from vscode-deploy-reloaded.

Having the same issue :(

from vscode-deploy-reloaded.

@mkloubert any update ?? is there any alternative way to solve this issue ?

from vscode-deploy-reloaded.

Same here...

from vscode-deploy-reloaded.

Same error on macOS 11.5.1

from vscode-deploy-reloaded.

I reverted to 1.58.2 until it's sorted out.

Do you share the link to download this version for MAC please ? On the officiel website only the last version are available

from vscode-deploy-reloaded.

I find a way. Last year I need switch form Deploy to Deploy (reloaded)... Now We need switch form Deploy (reloaded) to Deploy. Fix the problem for me on mac OS.

from vscode-deploy-reloaded.

Here the same problem :/

from vscode-deploy-reloaded.

Can confirm. VS Code 1.59 update broke this version. Edit: Workaround below works a treat!

from vscode-deploy-reloaded.

Cool, workaround rocks!

from vscode-deploy-reloaded.

Yes I applied the same workaround. I think is just some npm that were not included.

from vscode-deploy-reloaded.

balbertho had the working solution. Thanks!

from vscode-deploy-reloaded.

the last update is 0.89.0 (August 17th, 2019; fixed HTML viewer) ...
@mkloubert the product is deprecated or you need some maintainers ?

from vscode-deploy-reloaded.

Suddenly this seems relevant once again
#74

from vscode-deploy-reloaded.

macOS Big Sur 11.5.2
Visual Studio Code 1.59.1
deploy-reloaded v0.88.0 + v0.89.0

When I try to use Command Deploy Reloaded: Deploy... Command 'Deploy Reloaded: Deploy ...' resulted in an error (command 'extension.deploy.reloaded.deploy' not found) pops up.

Onsave deploy doesn't even do anything, I assume because vscode doesn't recognize the extension based on the error above.

I reinstalled vscode, I reinstalled the extension but I can't get it running. It's unfortunately an issue for quite some time for me, I just didn't had time to look on it.

from vscode-deploy-reloaded.