Comments (4)
Thanks for the feedback! I fixed this in the latest version by adding an error argument to the callback; however, for the next version, I believe I'll make the callback arguments optional and provide convenience methods.
from moira.
hi. thanks very much for the speedy reply.
just an fyi for the future (not for now): the usual node.js convention is to make the "err" parameter the first parameter, and if that parameter is non-null, then the callback ignores the other parameters, e.g.,
…, function(err, results) {
if (!!err) return console.log('callback: ' + err.message);
…
});
i'm not suggesting that you change moira to use that, just that you keep it in mind for the future
from moira.
Thanks for the suggestion. The new code addresses this (null is now returned instead of false) and is much cleaner. I noticed that MOIRA is a dependency in some of your projects; please be aware that I moved err to the first parameter position in getIP().
from moira.
got it, thanks!
from moira.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moira.