Support for sig_passthrough option of Net::Server about starman HOT 13 CLOSED

Out of curiosity what do you want to achieve by enabling that option?
—
Sent from Mailbox for iPhone

On Tue, Apr 9, 2013 at 3:09 AM, Wallace Reis [email protected]
wrote:

Hi,

I couldn't find any way to set sig_passthrough option for Net::Server out of box. Please advise if there is any known path, otherwise I will be happy to try and do a patch.

Reply to this email directly or view it on GitHub:
#68

from starman.

Logfile rotation with logging controlled by Log4perl.

from starman.

OK. Doesn't that require passing log4perl related params as well or could
it be done with the current interrace?

from starman.

The log4perl related params in order to have it adding the signal handler for file recreation is processed from its config file - in my case, set from config-file of the application. So, it can be done with the current interface.

from starman.

Just curious, can you show me how? config file of which?

I thought log4perl support is baked in Net::Server but i might be confusing with something else.

from starman.

https://metacpan.org/module/Log::Log4perl#Initialize-via-a-configuration-file

with:
log4perl.appender.LOGFILE.recreate: 1
log4perl.appender.LOGFILE.recreate_check_signal: USR1

So, I have a log plugin which integrates log4perl with the app and process everything in "logging" part of app's config-file and seeds Log::Log4perl's initialization. Is it clearer?

from starman.

Yes it's clearer. And it's unfortunate that the USR1 conflicts with what Unicorn's log rotation flags, so i might have to think about it. http://unicorn.bogomips.org/SIGNALS.html

(This is why I ask what you want to achieve with that change, so that it won't conflict with my design process.)

from starman.

Right. That is good discussion anyway and makes sense as base for documentation. :)

The good thing is that it does not need to be USR1 as it is totally parametrized. So, I could tell the log4perl to install another one (USR2 or whatever) and pass "--sig-passthrough USR2" to the server initialization.

from starman.

We also ran into a similar situation where it would be very useful to set sig_passthrough for an internal use of SIGUSR1. Would you accept a pull request to allow setting this?

from starman.

#111 added passing through Net::Server options with the --net_server- prefix (or via directly creating Starman::Server instance). Does that work for you?

from starman.

Yes, it does. Thanks! The prefix seems to be --net_server_ rather than --net_server- though.

from starman.

No, it is --net_server-. (It actually accepts both)

from starman.

Ah, ok. I just looked at the diff. I didn't realize Plack::Runner mangled the params before that point.

from starman.