Giter Club home page Giter Club logo

Comments (5)

connor4312 avatar connor4312 commented on August 22, 2024

Resolved in the linked commit ^ https://peet.io/i/18-05-rmx66nknlgvf6503jitvnal8lrtgb8.mp4

from cdk.

dori4n avatar dori4n commented on August 22, 2024

Wait, why is that even a thing? And why do you use the name from the project.json file?
Shouldn't this just be ignored and the control upload simply be tied to the interactive project version?
This just caused me a headache of two hours trying to figure out why deployment got stuck after after cloning @mixer/cdk-preact-starter, opening the folder it in the CDK (which doesn't detect the node_modules directory isn't present because the dependencies aren't installed, yet, when you do this, either, by the way) and running npm i && npm i --dev (after which I had to restart it, too, to make it work...)

from cdk.

connor4312 avatar connor4312 commented on August 22, 2024

Hi, thanks for your feedback. A single control bundle can be linked to multiple interactive projects, so it needs a unique identifier; the name from the package.json works well. Sorry for the headache, that should be resolved in our next release when the linked commit comes out.

which doesn't detect the node_modules directory isn't present because the dependencies aren't installed

See #102

from cdk.

gostay avatar gostay commented on August 22, 2024

I wrote up a separate issue related to this: #125 (as a separate issue since it's a feature request different from this Project Name Taken error messaging), but it's relevant to this conversation, I think.

from cdk.

dori4n avatar dori4n commented on August 22, 2024

A single control bundle can be linked to multiple interactive projects, so it needs a unique identifier

If that is the case, then why is there no separation from the interactive projects and the control bundles and a way to manage the control bundles and which interactive project uses which control bundle instead? Like, how would I even go about authoring a control bundle, publishing it, letting my users use it for their interactive projects, and update it independently?

the name from the package.json works well

Er, no. No, it doesn't. When working in a team, and I would think working on your first party solutions would have made this obvious immediately, I couldn't have all of them have unfettered access to the production bundle, or use it for testing, or have them all change the project name and fuzz about constantly having to avoid checking it into version control. That's just crazy talk.
Please generate a bundle ID randomly, store it locally for reuse, and dispose of uploaded bundles that aren't linked to any interactive projects.

from cdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.