Ppmd8_DecodeSymbol should be received by int, not unsigned char. Then stop decoding if <0 about pyppmd HOT 8 CLOSED

Could you propose the change for your proposal over #33 (when merged)?
It is OK to drop "end marker".

from pyppmd.

It is in https://github.com/cielavenir/pyppmd/commits/UseEndmarkProperly2 , but see #33 (comment) first.

from pyppmd.

Note: An implementation of "end mark" is partially compatible with unrar does.

from pyppmd.

#33 changed to do it. (don't touch end mark code)

from pyppmd.

@miurahr

Firstly, both 7z and rar uses PPMdH and zip uses PPMdI.

Then actually ppmd has quite many dialects - although 7z and rar uses PPMdH, the rangecoders are different. It is also different from the original PPMd to unpack PPMd archive format described in http://www.compression.ru/ds/ .

So it is free to have different endmark handling [edit: across softwares].

Maybe adding option to set the endmark handling is an idea.

from pyppmd.

Now you can pass endmark option to encoder and decoder.

ref: #39

from pyppmd.

@miurahr thank you

from pyppmd.

@miurahr I confirmed the compatibility of current pyppmd and I was able to release https://pypi.org/project/zipfile-ppmd/ as zipfile module patcher, which works the same way as zipfile-zstd. Thank you.

from pyppmd.