CentOS 7: pthread_setname_np issue about mitsuba HOT 5 OPEN

cc @amyspark

from mitsuba.

Yes, my mistake (I was setting up Travis in my fork and it bit me). I've amended #38 to close this issue as well.

from mitsuba.

The same file src/libcore/thread.cpp, line 444 : pthread_setname_np(threadName.c_str());

line 444 runs on OSX, I wonder whether it has the same issue ? @amyspark

from mitsuba.

Line 444 works in MacOS because its pthreads library does not require the thread name. Conversely, Linux does, and this is why the build breaks in line 637:

PTHREAD_SETNAME_NP(3)    BSD Library Functions Manual    PTHREAD_SETNAME_NP(3)

NAME
     pthread_setname_np -- set the thread name

SYNOPSIS
     #include <pthread.h>

     void
     pthread_setname_np(const char *name);

DESCRIPTION
     The pthread_set_name_np() function sets the internal name for the calling
     thread to string value specified by name argument.

AUTHORS
     This manual page was written by Alexey Zelkin <[email protected]>.

BSD                            February 13, 2003                           BSD

My mistake was in #34, I replaced the old prctl call without testing it in Linux.
Try the pull request I linked. Does it still fail for you?

from mitsuba.

Mitsuba 0.6.0 works well on CentOS 7, thanks a lot. @amyspark

from mitsuba.