Missing include `unistd.h` in `generalclient.hpp` about flightgoggles HOT 4 CLOSED

from flightgoggles.

Hi Philipp, Sorry about that. A pull request would be appreciated! Thanks, -Winter
…
On Mon, Feb 11, 2019, 02:28 Philipp Föhn @.***> wrote: Hi and thanks for releasing FlightGoggles I met an issue while compiling on Ubuntu18.01 with ROS Melodic. flightgoggles/flightgoggles_ros_bridge/src/GeneralClient/GeneralClient.cpp uses sleep() and usleep() but neither the header nor the source include it. It is easily resolved by including unistd.h in the source (preferred) or the header. Shall I do a pull request or do you fix it quickly by committing? Thanks a lot! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#34>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOwrhxqV4pWeMFFP9hW2PZOB2fsyeuIks5vMRungaJpZM4azpel .

Here @Winter-Guerra #39

from flightgoggles.

@BhavyanshM
@Winter-Guerra

thanks a lot!

from flightgoggles.

PR merged. Thanks @BhavyanshM and @foehnph for catching this issue! We're running 16.04, so we didn't see this issue before. GCC in 16.04 seems to automagically include the file.

from flightgoggles.