Giter Club home page Giter Club logo

Comments (3)

jywarren avatar jywarren commented on August 15, 2024

Just noting also seems similar to #209 (comment)

Agree, Apple is so frustrating on these issues... :-(

from photo-sphere-viewer.

jywarren avatar jywarren commented on August 15, 2024

iPadOS v 17.4.1 (Chrome + Safari) works
iOS (iPhone) 16.77 (Chrome + Safari) does NOT work
iOS (iPhone) 16.2 (Safari) seems to have some other error preventing the whole page from loading, will open a separate issue... #1315 but will come back here to update for this device if I work around it

Update: iOS (iPhone) 16.2 (Chrome + Safari), once I get past #1315, does NOT work - same undefined is not an object error

from photo-sphere-viewer.

jywarren avatar jywarren commented on August 15, 2024

This error doesn't seem to match the code I'm actually seeing in latest main branch:

Photo-Sphere-Viewer/packages/core/src/utils/browser.ts

Lines 141 to 152 in 554361f

/**
* Enters fullscreen mode
*/
export function requestFullscreen(elt: HTMLElement, isIphone = false) {
if (isIphone) {
fullscreenElement = elt;
elt.classList.add('psv-fullscreen-emulation');
document.dispatchEvent(new Event('fullscreenchange'));
} else {
elt.requestFullscreen();
}
}

looking further...

Waaaah hooray! @mistic100 already fixed this just days ago: ea0260a

Will test in https://github.com/mistic100/Photo-Sphere-Viewer/releases/tag/5.7.4

In any case, many thanks and wow you fixed a bug 5 days before it was reported... amazing!

from photo-sphere-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.