Comments (3)
Please, can you send an example input where this happens? (or at least some screenshot of the output showing the described artifact). The outputs from mgm and tvl1 are dense at the beginning, but then they are filtered immediately and the validity mask is used everywhere. I think I do not understand the issue...
from s2p.
I think the problems show up before even invoking mgm and tvl1, in the pre-processing of inputs. And then the filtering cannot solve them. But I could be wrong.
Here is all data, inputs and outputs:
https://byss.arc.nasa.gov/oalexan1/bug.tgz
The DEMs I obtained, with TV-L1 and MGM:
test_bug_tvl1_old/dsm.tif
test_bug_mgm_old/dsm.tif
You can see noise, especially for the MGM one, on the left. The input images don't have that noise.
Here are some intermediate images showing the noise before running the correlation step:
./test_bug_tvl1_old/tiles_row_2612_height_1304/col_3144_width_1571/pair_1/rectified_ref.tif
./test_bug_tvl1_old/tiles_row_2612_height_1304/col_3144_width_1571/pair_1/rectified_sec.tif
./test_bug_mgm_old/tiles_row_2612_height_1304/col_3144_width_1571/pair_1/rectified_ref.tif
./test_bug_mgm_old/tiles_row_2612_height_1304/col_3144_width_1571/pair_1/rectified_sec.tif
I think the problem is filling with incorrect values.
I attached all inputs, so you can reproduce this. There are two config files, that you can use:
config_mgm.json
config_tvl1.json
In my images, where there is no valid input, I use a no-data value, as it is standard with Tif images. I think S2P does not understand it and thinks that that data is valid. Does S2P have a way of providing a mask for the input data?
My own version of S2P is 3-4 months old. If you cannot reproduce the problem, maybe it is fixed.
Thank you.
from s2p.
Here is another testcase which should be much easier to debug:
https://byss.arc.nasa.gov/oalexan1/bug2.tgz
There is again a .json file containing all settings.
In this example, all input pixels are valid. Yet, when alignment takes place, images are rotated. Empty areas show up where there is no valid value. They are again are filled in, and then in callTVL1.sh the valid and fake values are mixed. Here is an example from this testcase illustrating that:
test_ice_tvl1_img23_undist_bilinear3_crop5_old/tiles_row_0_height_1811/col_0_width_1474/pair_1/rectified_ref.tif
test_ice_tvl1_img23_undist_bilinear3_crop5_old/tiles_row_0_height_1811/col_0_width_1474/pair_1/rectified_sec.tif
And the final DEM is incorrect, as you see here:
test_ice_tvl1_img23_undist_bilinear3_crop5_old/dsm.tif
I was able to get good results by running callTVL1.sh on images which were pre-aligned, while avoiding S2P's alignment part.
I ran MGM on this dataset as well. One tile of the 6 failed, and there was a lot of noise too.
from s2p.
Related Issues (20)
- Dockerfile not comment correctly and should add apt-get install unzip HOT 1
- Cannot get S2P to work on IARPA challenge data HOT 6
- How to use the value in rpc.XML to reproject raster.tif? HOT 2
- incorrect disparity range manipulation
- Unable to run docker image HOT 2
- creating constant fixed size for rectified_ref.tif and rectified_sec.tif
- s2p stuck without any output HOT 3
- egm96-15.pgm missing in docker
- Utilities/Utilities.cpp:17:17: fatal error: png.h: File o directory non esistente HOT 4
- input_pair Test Failure HOT 3
- how to use Digital Globe's (DG) stereo-pair images with S2P HOT 1
- Failed building wheel for s2p HOT 3
- How get GeoTIFF's RPC HOT 1
- Just Pancromatic? HOT 1
- How s2p find out the correct coordinates with only RPC model?
- Unable to generate colored point clouds
- Colab 'ERROR: Failed building wheel for s2p' HOT 1
- Run the exact same code, data, and parameters on AWS and my laptop lead to different results HOT 2
- Error - exit status -6 HOT 4
- Multiple sources for this repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s2p.