mispp / goat Goto Github PK

Via odbc?

• colors should be randomly assigned in connection manager upon creation
• each connection should by default have different color (so check what is assigned and pick another one)
• this can be manually overridden and color selected
• tab should include both icon of database (elephant for postgres, etc) and color somehow

focus is picked on random controls/components based on events.
this should be streamlined so it doesnt look ridiculous.

example:

1. open a connection
2. write a query and select it
3. click 'run selection' button in QueryTab

current results: combobox with open connections receives focus
expected result: codeeditor should have focus?

To reproduce

• open a connection
• query "select * from table;"
• open a new tab
• close/remove the connection
• switch to the tab that ran the query

currently, when new connection is established, first connection in a list is selected.
change behavior to select new connection

Based on the comments in this thread, it seems that using QSqlQueryModel will not work with Forward-Only queries.

For this reason, the model behind table view will have to be redone:

• use QStandardItemModel
• QStandardItemModel should be inherited and extended for coloring of null values -> if in a cell is a null value, background should be colored yellow
• while extracting data, do it in sets of 1000 rows
• do it in a threaded way

WARNING: for threaded way and forward-only queries, single database connection cannot be used by multiple threads. to solve this, either resource/connection pooling has to be implemented or connection should be cloned, opened and closed within each thread. having connection opening/closing within a new thread will have to be considered while extracting data from query results in chunks.
this question on stackoverflow should be of use

this applies to scenario when a new connection is added. before adding new connection to model behind combobox, model first gets cleared.
to fix this, before .clear, save connection id / name so it can be restored upon filling model again.

what comes to mind for first options

• background color for results grid
• font and size for editor
• forward-only chunk size for queries

performance is not satisfactory on bigger result sets.

e.g. following query kills the GUI (1500x1500 rows):

select
   i.*
from
    information_schema.columns i
    ,information_schema.columns p

something like this:
are you sure you want to close -> there are unsaved changes, save them?

steps to reproduce:

1. start app and initiate a connection
2. in automatically created new tab (Untitled), open a .sql file by clicking on 'open file button' in main toolbar
3. create a new tab
4. in new tab, write some query and execute it
5. click on 1st tab

by executing step 5, tab becomes marked as changed even though no interaction with contents of that tab was done

add objects like schemas, tables, views, columns and procedures/functions

right now it is just thrown randomly on the screen.

i'm not sure if this is wayland issue in kde or general issue with showing dialogs which needs to be handled by app

different icons for:

• numeric (double, int, decimal,...)
• date and datetime
• character and text
• other
  • maybe json and specific postgres datatypes

might be of use:

https://stackoverflow.com/questions/10820919/how-to-display-icons-in-qtableview-via-a-custom-qabstractitemmodel

• will add ability to move toolbar around UI
• not sure how it will work with button with dropdown (connection manager)

Example:

SO suggestion:

https://stackoverflow.com/questions/35575564/qtableview-setting-a-cells-font-and-background-colour

in mssql management studio, several queries can be executed and several result sets can be displayed at once.

to be considered if this can be implemented

examples:

Not sure if this happens because of wayland (because there are some issues with rendering when two monitors of different dpi are connected) or because icons are really small.

Look for another icon set - in svg instead of png.

prevent showing of per-tab cloned connection in GUI

some ideas:

• take out QSqlQuery in it's own class called Query which should implement functions

  • QList<QStandardItem*> nextResultsChunk(int chunkSize)
  • void stopQuery()
  • bool reconnectDatabase()
  • executeQuery(QString query)

• not sure how to handle this QAction thing for the QToolButton

  • currently there is a slot in ConnnectionManager that takes .data() from sender() -> i have a bad feeling about this implementation and no idea how to make it better

• take out the loop from refreshConnectionActions() from MainWindow and move it to connection manager. i guess function has to stay here to first clear old actions before loading new ones

need a way to cancel long-running query.
m_sqlQuery.finish(); and m_queryFuture.cancel(); are not doing anything

option could maybe be to kill a cloned (!) connection

Like AUTO_IS_NULL

two conditions:

• tab contents must be unmodified
• tab contents must be empty

if those are met, open the file in the current tab and rename it to the filename

makes more sense

connection management needs to be reworked. goal here is to implement behavior similar to mssql management studio. this means:

• every tab can have a different connection to different database (tab1-> mysql, tab2->postgres, tab3->mssql).
• each tab should be easily identifiable which connection is used
• each tab should easily switch connection it is using
• long running query in one tab must not affect other tabs

Therefore,

• connection manager dialog should be brought back and establishing connection should be handled through it, optional toolbar/treeview control should be added to display established connection
• menu list of established connections should be added
• disconnecting should be done based on a list of established connections shown in mentioned tree view control
• mentioned treeview control would later be used also to view objects in databases (e.g. list tables, then for each table list columns; list users; etc.)
• to be able to easily identify which connection is used dropbox and execute button(s) should be brought back into the tab itself

Can be repeated with create table statement

move toolbar to the left of the tab

steps to reproduce:

1. start app (it will automatically open a new tab)
2. open a file in this unmodified tab
3. select on the tab combobox
4. close tab

Travis, google cloud, whatever works

The button currently exists but is not hooked up to anything

when opening two tabs, then closing only the first one, both tabs will be closed.

Timestamp: 2018-53-11 17:53:21
Elapsed: 1 ms
ERROR: syntax error at or near "1"
LINE 1: select *1 from b
^
(42601) QPSQL: Unable to create query

now, code editor is just extension of qplaintextedit, which is ok, but following features need a lot more work:

• improvement of the syntax highlight for multiline comments
• row numbers
• vertical lines on the right (80 chars)
• code completion
• code folding (not really that necessery)

these features are integrated into qscintilla and ktexteditor, so their usage might be the way to go.

• for ktexteditor switch to cmake is needed
• for qscintilla settings and color selection for highlight type needs to be further investigated, also how to get 'query at cursor' to submit with ctrl-enter. qscintilla is taken fro sqlitebrowser for testing and is in a separate branch

not sure why, but this might be caused by mishandling qsqlquery