Giter Club home page Giter Club logo

Comments (3)

thewilkybarkid avatar thewilkybarkid commented on May 23, 2024

After a quick bit of looking into this:

  • The PhoneNumber constraint has a type property (designed for 'fax', 'mobile' etc) which is currently a placeholder. This won't work (I think) as it needs to be translated itself, so it looks like the message will have to be constructed here (with care taken to maintain BC). Suggested default support types are 'phone', 'mobile', 'fax' (note that these are just labelling rather than such granular validation).
  • In #1 we added a friendly invalid message to the PhoneNumberType, but I'm wondering whether this should be removed and so the field uses the same message as other types (ie "This value is not valid") for values such as 'foo'.

Based on that, the only strings to translate look to be:

  • This value is not a valid phone number.
  • This value is not a valid mobile number.
  • This value is not a valid fax number.

(Unless generic messages such as "Phone number" are dealt with for field labels etc. Does any public bundle do this kind of thing?)

from phone-number-bundle.

thewilkybarkid avatar thewilkybarkid commented on May 23, 2024

Thinking about this again, it's probably not a good idea to have a type property that doesn't actually do anything. Instead, using PhoneNumberUtil::getNumberType() should allow us to check what the number is (usually wanting to know mobile or fixed line).

This may prove difficult to translate.

from phone-number-bundle.

thewilkybarkid avatar thewilkybarkid commented on May 23, 2024

Fixed in #15

from phone-number-bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.