Comments (3)
After a quick bit of looking into this:
- The
PhoneNumber
constraint has atype
property (designed for 'fax', 'mobile' etc) which is currently a placeholder. This won't work (I think) as it needs to be translated itself, so it looks like the message will have to be constructed here (with care taken to maintain BC). Suggested default support types are 'phone', 'mobile', 'fax' (note that these are just labelling rather than such granular validation). - In #1 we added a friendly invalid message to the
PhoneNumberType
, but I'm wondering whether this should be removed and so the field uses the same message as other types (ie "This value is not valid") for values such as 'foo'.
Based on that, the only strings to translate look to be:
- This value is not a valid phone number.
- This value is not a valid mobile number.
- This value is not a valid fax number.
(Unless generic messages such as "Phone number" are dealt with for field labels etc. Does any public bundle do this kind of thing?)
from phone-number-bundle.
Thinking about this again, it's probably not a good idea to have a type
property that doesn't actually do anything. Instead, using PhoneNumberUtil::getNumberType()
should allow us to check what the number is (usually wanting to know mobile or fixed line).
This may prove difficult to translate.
from phone-number-bundle.
Fixed in #15
from phone-number-bundle.
Related Issues (20)
- Exception on form rendering when using Synfony 4 build-in Bootstrap 4 form support HOT 3
- PhoneNumberType is overriding template for Symfony TelType HOT 1
- Extensions Are Silently Dropped HOT 4
- Missing phone_number_parse Twig filter
- JMS Serializer: return empty phoneNumber: [] HOT 3
- Support `default_region` for `PhoneNumberType` with option `'widget' => PhoneNumberType::WIDGET_COUNTRY_CHOICE`
- Pulling in misd/phone-number-bundle with composer is causing memory limit to be exhausted
- How to deal with numbers saved before phone-number-bundle implementation?
- Country choice custom text
- My form submission is always invalid HOT 3
- Missing require in composer HOT 2
- New release HOT 4
- Symfony templating component required HOT 2
- PhoneNumberValidatorTest fails on CI HOT 1
- Deprecations from Twig
- Allow multiple type HOT 2
- Add support for symfony 4.4 HOT 3
- Abandoned in favour of `odolbeau/phone-number-bundle` HOT 8
- Regular Expression Issue for Iranian Mobile
- Is this bundle abandoned? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phone-number-bundle.