use buildViolation about phone-number-bundle HOT 10 CLOSED

@mablae You can check if the Symfony\Component\Validator\Context\ExecutionContextInterface interface does exist (which was introduced in Symfony 2.5):

if (interface_exists('Symfony\Component\Validator\Context\ExecutionContextInterface')) {
    // Symfony 2.5 or higher
} else {
    // Symfony before 2.5
}

from phone-number-bundle.

I've prepared a PR to fix this issue. I had to adapt the code to work both for Symfony < 2.5 and Symfony 2.5+. Raising the requirements of Symfony to at least 2.7 which is LTS would help with future tickets too and would make life easier because we could simplify some parts of the code that are now a real mess, e.g. the unit tests that have to handle different ExecutionContext classes (I don't remember in which version it was added but I know that there is now a documented trait to use for the unit tests of a validator that should handle all cases).

from phone-number-bundle.

ping @rh389 can we please move forward on this if it's still valid?

from phone-number-bundle.

The bundle supports versions before 2.5 (ie 2.3) so can't use buildViolation() yet. Future versions can do.

Regarding the path, this sounds like #19.

from phone-number-bundle.

@thewilkybarkid You could do the buildValidation() call conditionally (depending on the installed version of the Validator component).

from phone-number-bundle.

@thewilkybarkid ok i understand, you are right. Then the idea of xabbuh could be a solution.
Or you could maybe then replace addViolation with addViolationAt and do so:

private function addViolation($value, Constraint $constraint)
    {
        $this->context->addViolationAt(
            $constraint->atPath,
            $constraint->message,
            array('{{ type }}' => $constraint->type, '{{ value }}' => $value)
        );
    }

It would be really nice if you would give an option to decide where the violation message should appear.

from phone-number-bundle.

@thewilkybarkid What's about a master-branch for Symfony 2.7+, 2.8+ or 3.0+ and a current stable branch for the current code? Then you could use these new features.

from phone-number-bundle.

Interesting. @xabbuh can you give an example how such a version check would be done proplery?

from phone-number-bundle.

ping @thewilkybarkid any news on this? PR is ready to be reviewed

from phone-number-bundle.

#108 is now merged, so closing this.

from phone-number-bundle.