Giter Club home page Giter Club logo

Comments (9)

miraclx avatar miraclx commented on May 25, 2024 1

I'll take a look. Thanks.

from freyr-js.

miraclx avatar miraclx commented on May 25, 2024

Can you provide a use case? What are you trying to do that isn't working?

from freyr-js.

wisetc avatar wisetc commented on May 25, 2024

@miraclx

docker run --rm -it --entrypoint bash --name freyrcli -v $PWD:/data -v ./conf.json:/freyr/conf.json freyrcli/freyrjs-git:pr-214 -c "freyr apple_music:track:157624199"
266641497-6d6b866e-8f15-4851-83e2-0b0486a2759e

as you can see, Zero sources found.

but indeed, we can get result from youtube music

image

How can I download it?

from freyr-js.

wisetc avatar wisetc commented on May 25, 2024

Top result is not included in result.

    TITLE_TEXT: ['title', 'runs', 0, 'text'],
    HEADER_TITLE_TEXT: ['header', 'title', 'runs', 0, 'text'],

maybe "Top result" always using a header

image

And I think that language settings is not related to this issue as mentioned above. I'm wrong.

from freyr-js.

wisetc avatar wisetc commented on May 25, 2024

It seems that stripText will remove characters when calling StripChar.RSspecChar.

StripChar RSspecCharC' 1 q好 1d)

I don't think need to be striped.

maybe it works well when dealing with english songs, thanks for your work.

I'm just reporting this case.

from freyr-js.

miraclx avatar miraclx commented on May 25, 2024

Valid point, I hadn't tested with non-Latin glyphs. What is this string? File name? Track name?

from freyr-js.

wisetc avatar wisetc commented on May 25, 2024

Valid point, I hadn't tested with non-Latin glyphs. What is this string? File name? Track name?

@miraclx Track name.

for example: 忙與盲

thank you.

from freyr-js.

miraclx avatar miraclx commented on May 25, 2024

non-Latin support for source feed lookups implemented in #574. Thanks for raising this.

from freyr-js.

miraclx avatar miraclx commented on May 25, 2024

Just leaving a note here: The issue left here (may) be tied to the issue in #576, and could be resolved by a single fix that merges track results in all sections from the YouTube Music search.

from freyr-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.