Giter Club home page Giter Club logo

Comments (22)

LeBradshaw avatar LeBradshaw commented on May 26, 2024

image
Read through an old ticket and tried disabling the net check, got this.

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

A new release is yet to be cut. And the old releases still have now-invalid credentials.

Reinstall freyr using the latest version of the source code.

npm install miraclx/freyr-js

from freyr-js.

LeBradshaw avatar LeBradshaw commented on May 26, 2024

Okay, tried that but it doesn't seem to have changed anything. Got this during the install, so it could be related.
image
It still says version 9.0, what should it say?

from freyr-js.

LeBradshaw avatar LeBradshaw commented on May 26, 2024

image
also checked the source instructions and triied the line from there

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

It still says version 9.0, what should it say?

0.9.1

Try this instead

$ git clone https://github.com/miraclx/freyr-js
$ cd freyr-js
$ npm install
$ npm link

Now, try using freyr again. It should say 0.9.1

from freyr-js.

LeBradshaw avatar LeBradshaw commented on May 26, 2024

Thanks for reaching out! Unfortunately, now it says 0.10.0.... and still detects no internet connection. Maybe I should try on a different machine, but I can't help bt wonder what's causing that.

image

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

Yeah, I just released 0.10.0. You can npm install that since it's up to date.

As for the network issue, there's still work to be done. Try adding --no-net-check to make sure freyr behaves correctly without the check. And we'll figure out why the check fails.

from freyr-js.

LeBradshaw avatar LeBradshaw commented on May 26, 2024

Cool! That's great to hear, I've been pretty stoked about this project.

image

here's the --no-net-check, it seems to be executing fine besides the network hitch.

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

It hasn't made any network requests yet. It validated the input query and reported that it doesn't support YouTube links.

You have to use either a Spotify, Apple Music, or Deezer link.

from freyr-js.

LeBradshaw avatar LeBradshaw commented on May 26, 2024

Well how about that!

image

It still fails the net check, but seems to work if you skip it. After this I tried it in a directory that wasn't system32 and it worked beautifully! Fantastic!

from freyr-js.

LeBradshaw avatar LeBradshaw commented on May 26, 2024

It doesn't work for apple music, about to try Deezer.

image

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

Seems like a weird link. Does that open in the browser? It normally doesn't say /song/, it says /album/.

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

Apparently so! I just tested it with a custom link

https://music.apple.com/us/song/1699712652 opens a song-specific page, whereas the standard https://music.apple.com/us/album/delresto-echoes-feat-beyonc%C3%A9/1699712635?i=1699712652 highlights the song as part of the album.

I'll open an issue tracking the support of this format.

from freyr-js.

LeBradshaw avatar LeBradshaw commented on May 26, 2024

Indeed! and I can confirm that trying to download the whole album works fine.

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

@LeBradshaw, I've added support for song-type URLs like in your case - #552.

I'll cut a release as v0.10.1. After which, when you update, it should work just fine.

Thanks for contributing to making freyr more capable!

from freyr-js.

miraclx avatar miraclx commented on May 26, 2024

As for the network connection issue, I think we should try a few things:

$ curl https://icanhazip.com
107.53.232.145

You should see an IP address, which represents your public IP.

If that works, we can proceed to more involved steps to find out what exactly is up with freyr

$ git clone https://github.com/miraclx/freyr-js
$ cd freyr-js
$ npm install

Now, let's step into an interactive node session to inspect

$ node
> let pip = await import("public-ip");
> pip.publicIp({ onlyHttps: true });
107.53.232.145

You should see the same IP address as earlier.

from freyr-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.