Album fails to export ("No such file or directory") about freyr-js HOT 7 CLOSED

Patch submitted on sindresorhus/filenamify#23

from freyr-js.

Works perfectly.

from freyr-js.

I suppose this is an issue with NTFS' file name formats. I can't tell for sure however but this works on my system (with ext4). We'd need more information to proceed with fixing this. Can you try manually creating the file path?

• Mori Calliope
  • Your Mori.
    • 01 The Grim Reaper is a Live-Streamer.m4a

from freyr-js.

I suppose this is an issue with NTFS' file name formats.

I created the folder with the name "Your Mori." and it put all the songs into a folder "Your Mori" without the period, seemed to do some weird things. It's most likely a NTFS file format naming thing because it let me delete the "Your Mori." folder but when I create a new folder it renames "Your Mori" to "Your Mori."

This is all pretty wacky, but yeah I don't think folders like having periods in their names. The solution here would probably be running regex on the names of folders (doesn't seem to be a problem with the songs themselves)

function cleanUp(instring) {
    return instring.replace(/[\\/?.:<>|"*]/g, '');
}

from freyr-js.

freyr already uses filenamify to ensure file and folder names are safe depending on the filesystem, it's exclusion filter [<>:"/\\|?*\u0000-\u001F] doesn't include . (period) so it doesn't filter that out.

However, after seeing https://superuser.com/a/585119/974653, a match on trailing period(s) would make sense.

so this is more of a:

function cleanUp(path) {
    return filenamify(path).replace(/\.+$/, '');
}

I'll do a little more investigating, this patch might actually belong in filenamify itself, so it's better for everyone.

from freyr-js.

I'm guessing this was fixed on c5e7e8c, I'll run a test now.

from freyr-js.

Yup! You can close this PR at will.

from freyr-js.