Giter Club home page Giter Club logo

Comments (6)

hongbo-miao avatar hongbo-miao commented on August 16, 2024 1

Works perfect now! Even another ESC not respond issue also fixed! Thank you so much!

from react-popup.

tbleckert avatar tbleckert commented on August 16, 2024

When updating you should've gotten a notice about keymaster being required. As React (and React DOM), Keymaster is listed as a peer dependency. Simply npm install keymaster. Maybe this should be in the documentation or maybe even a direct dependency.

In npm 3 they removed automatic installs of peer dependencies and I know that have caused some confusion for lots of developers.

from react-popup.

hongbo-miao avatar hongbo-miao commented on August 16, 2024

Oh, actually have more issues. Still same codes

<Popup
  closeBtn={false}
  closeOnOutsideClick={true}
  escToClose={true} />
const popup = Popup.register({
  content: <MyComponent />,
  noOverlay: false
});

After installing

    "keymaster": "1.6.2",
    "react-popup": "0.9.0",

met this

image

from react-popup.

tbleckert avatar tbleckert commented on August 16, 2024

Yeah, I saw that too late, but was patched in 0.9.1 minutes after 0.9.0. A tip is to always install for example ~0.9.0 or 0.9.x, regardless of which package you're using, that'll ensure you'll always have patches.

from react-popup.

hongbo-miao avatar hongbo-miao commented on August 16, 2024

Thanks, I will try again when npm shows 0.9.1

from react-popup.

tbleckert avatar tbleckert commented on August 16, 2024

Glad it works and thanks for the bug reports!

from react-popup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.