Comments (6)
Works perfect now! Even another ESC not respond issue also fixed! Thank you so much!
from react-popup.
When updating you should've gotten a notice about keymaster being required. As React (and React DOM), Keymaster is listed as a peer dependency. Simply npm install keymaster
. Maybe this should be in the documentation or maybe even a direct dependency.
In npm 3 they removed automatic installs of peer dependencies and I know that have caused some confusion for lots of developers.
from react-popup.
Oh, actually have more issues. Still same codes
<Popup
closeBtn={false}
closeOnOutsideClick={true}
escToClose={true} />
const popup = Popup.register({
content: <MyComponent />,
noOverlay: false
});
After installing
"keymaster": "1.6.2",
"react-popup": "0.9.0",
met this
from react-popup.
Yeah, I saw that too late, but was patched in 0.9.1 minutes after 0.9.0. A tip is to always install for example ~0.9.0 or 0.9.x, regardless of which package you're using, that'll ensure you'll always have patches.
from react-popup.
Thanks, I will try again when npm shows 0.9.1
from react-popup.
Glad it works and thanks for the bug reports!
from react-popup.
Related Issues (20)
- "keymaster" package dependency missing in npm HOT 1
- Can't resolve 'keymaster' HOT 1
- Provide the possibility to set the callback when popup is closed not by clicking on the footer buttons HOT 2
- Error when adding popup to project HOT 3
- Properties lost when creating plugins HOT 1
- Can't call setState (or forceUpdate) on an unmounted component HOT 2
- EventEmitter memory leak HOT 3
- How to style text in the popup HOT 1
- wildClasses is no longer supported in version 0.9.3 HOT 1
- Uncaught TypeError: Cannot read property 'key' of undefined HOT 4
- Closing popup with back button HOT 1
- Callback for popup.close() HOT 1
- CSS styles acting differently in development vs production HOT 1
- Focus on a field
- React Popup does not access update state value
- How to use stylesheet? HOT 1
- Callback on click outside/dismiss or prevent click outside?
- typescript support
- Test HOT 1
- Missed `events` package causes crash
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-popup.