Comments (9)
Can you test please?
@pauloue Check it out, too.
from craftguide.
But I think it would be better to either not display these recipes at all or display them in a toggleable usages mode.
No, that sounds like a half-baked solution. Pretty sure there exists a better fix that lies in the code architecture and that does not involve any compromise.
from craftguide.
Works fine, thank you!
from craftguide.
Unfortunately this commit causes a serious performance regression also...
from craftguide.
It would be faster if you only get the usages if it's a fuel and there are no regular recipes. But I think it would be better to either not display these recipes at all or display them in a toggleable usages mode.
from craftguide.
I don't consider it a compromise. Performance issues aside, I think the current behavior of falling back to usages when there are no recipes is confusing because clicking on some items gives you usages while the rest give you recipes. It's also weird that this fallback is used only for fuel items and not other items that have usages but no recipes (e.g. default:key
).
from craftguide.
For info, this commit drastically improves the performance of get_filtered_items
.
from craftguide.
It did for me too and I was really confused as to why because it doesn't seem to change anything performance critical. So I reverted it and the performance improvement was still there. I think I know what was going on. Previously there was a bug that caused duplicate items to be added to inv_items
, making the craftguide slower every time I opened it. That bug was since fixed, but the inv_items
meta was never cleared, so the performance remained bad. Then when testing I cleared it and the performance was fixed.
Caching usages does make a noticeable difference when there is a ridiculous amount of registered items (dreambuilder) though.
from craftguide.
Talking about dreambuilder, caching all recipes/fuels/usages takes 55 seconds (<0.2s with MTG only).
from craftguide.
Related Issues (20)
- Craftguide inventory graphical issue HOT 8
- Searching the craftguide based on category HOT 2
- Runtime error on first run on new map HOT 4
- Server crashes on logout when mod is active. HOT 4
- Switch between Progressive and Complete mode within Game HOT 1
- Multiple crashes while trying to use craftguide for the first time HOT 1
- Invalid command: craft HOT 1
- Attempt to index local 'meta' (a nil value) HOT 4
- Mod crashes HOT 2
- Allegedly greatly increased load times HOT 2
- crash with latest version HOT 3
- Deal with items that have no recipe HOT 1
- Some recipes not being shown HOT 5
- mesecons_materials + basic_materials - Silicon lump recipe not shown HOT 10
- core.register_alias and core.register_alias_force should not be redefined HOT 9
- Misplaced 3x3 recipes HOT 1
- sfinv mode recipe out of border and other issues HOT 2
- sfinv_only mode does not work with progressive_mode HOT 1
- Craftguide data caching is not persistent HOT 26
- Inventory_plus support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from craftguide.