Giter Club home page Giter Club logo

Comments (15)

verymilan avatar verymilan commented on May 26, 2024

Today i updated xdecor and added the craftguide mod speratly - all pages are dead in my singleplayer game on the latest commit.

Edit: with and without creative

from craftguide.

kilbith avatar kilbith commented on May 26, 2024

@tchncs What do you mean by "all pages are dead" exactly ?

Also, are you using an engine development version ? If yes, at which commit are you on ?
Can you try with Minetest Game only and see if the issue happens ?

from craftguide.

verymilan avatar verymilan commented on May 26, 2024

@kilbith just nothing happens on click of any item on all pages.

from craftguide.

kilbith avatar kilbith commented on May 26, 2024

Thanks for the archive, @tchncs (I'll delete all the off-topic comments in the issue now).

So I checked with your subgame and I confirm that craftguide works perfectly fine with it.

Summary of the situation :

  • The issue is only reproducible among a few users ;
  • The issue has no common pattern (i.e. @Fixer-007 is having the issue only in page 1 with some items; while @tchncs is having the issue with all items on all pages) ;
  • The issue seems influenced with the language = setting in minetest.conf (@Fixer-007, correct me if I'm wrong) ;
  • The issue has random symptoms among the userbase, therefore it is hard to have a starting clue of where it could goes wrong into the mod's code (which looks correct).

This suggests me an engine bug for the moment.

from craftguide.

Fixer-007 avatar Fixer-007 commented on May 26, 2024
  • it may have some connection to minetest settings (?)
  • I've tried it with dreambuilder modpack and got nonworking crafts on many pages too

from craftguide.

kilbith avatar kilbith commented on May 26, 2024

I tried with dreambuilder as well and everything was functional.

from craftguide.

kilbith avatar kilbith commented on May 26, 2024

I confirm the issue is only happening on Minetest 0.4.14-stable. Try out on a engine development version or the upcoming 0.4.15-stable.

from craftguide.

Fixer-007 avatar Fixer-007 commented on May 26, 2024

Happens to me on newest builds

from craftguide.

verymilan avatar verymilan commented on May 26, 2024

Happens to me on newest builds

+1

from craftguide.

taikedz avatar taikedz commented on May 26, 2024

Last commit trying to fix this one breaks buttons somewhat randomly.

Reason: Line 338 elseif next(fields):finditem(":") is presuming it gets the item on first go, but the table api offers no such guarantee

from craftguide.

taikedz avatar taikedz commented on May 26, 2024

Problem #11 was likely this one line
d0b3cf2#diff-d7d74284e2e39f6c06d199c8e2bedbd0L340

from craftguide.

kilbith avatar kilbith commented on May 26, 2024

@taikedz No, it was happening even when the loop was there. Also when pressing the button, its field is always in first position. The issue is likely in the engine.

from craftguide.

kilbith avatar kilbith commented on May 26, 2024

Normally fixed : fa7a50fe

from craftguide.

verymilan avatar verymilan commented on May 26, 2024

I can confirm, works wonderful now. :)

from craftguide.

Fixer-007 avatar Fixer-007 commented on May 26, 2024

same for me

from craftguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.