Giter Club home page Giter Club logo

Comments (7)

gpkc avatar gpkc commented on May 31, 2024 1

@soerenmartius Yes there should be a placeholder but the explanation text states:

The email message template for sending a confirmation link to the user, it must contain the {##Click Here##} placeholder.

However, the default value contains {##Verify Email##} and not {##Click Here##}

from terraform-aws-cognito-user-pool.

soerenmartius avatar soerenmartius commented on May 31, 2024

Hi @gpkc,

thanks for reporting this. We implemented this module according to the information given in the documentation of the provider.

Imho, the placeholder is required since otherwise, Cognito will not be able to generate and insert the confirmation link?

from terraform-aws-cognito-user-pool.

soerenmartius avatar soerenmartius commented on May 31, 2024

@soerenmartius Yes there should be a placeholder but the explanation text states:

The email message template for sending a confirmation link to the user, it must contain the {##Click Here##} placeholder.

However, the default value contains {##Verify Email##} and not {##Click Here##}

@gpkc it seems that this has changed. Older version of the provider required it to be{##Verify Email##} as you can see here but indeed that's not correct anymore. I will provide a fix in a little while! Again, thanks for reporting this.

from terraform-aws-cognito-user-pool.

mariux avatar mariux commented on May 31, 2024

Afaik: it is required to have {##Any Text##} placeholder where Any Text will be the link text... so {##Click here##} should do as well as {##Verify Email##} as would {##Follow this link##}.

So whatever the tag shows should work in the context of the rest of the message - Which it does in the default?

The documentation is really bad in AWS for this.

I hope this helps.

from terraform-aws-cognito-user-pool.

gpkc avatar gpkc commented on May 31, 2024

Oh I see, that makes sense then. Yes the documentation seems to be very bad in that sense, as it's not mentioned anywhere that I could find that the text content is arbitrary. Thanks!
Might be that this can be closed then

from terraform-aws-cognito-user-pool.

soerenmartius avatar soerenmartius commented on May 31, 2024

I am gonna add this to the docs to avoid future confusion!

from terraform-aws-cognito-user-pool.

soerenmartius avatar soerenmartius commented on May 31, 2024

Closed in favor of #48

from terraform-aws-cognito-user-pool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.