Giter Club home page Giter Club logo

Comments (4)

XiaoPangxie732 avatar XiaoPangxie732 commented on June 2, 2024

Maybe this is because method parameter names are declared in SRG mappings, so could please add an option to regenerate method parameter names?

from forgeflower.

LexManos avatar LexManos commented on June 2, 2024

You've provided no context, and your first post doesnt actually explain what you're doing.
There already exists a flag to disable using bytecode LV names. So... Done.

from forgeflower.

TheCurle avatar TheCurle commented on June 2, 2024

(the flag is patched in by us, you can use it with -jvn)

from forgeflower.

XiaoPangxie732 avatar XiaoPangxie732 commented on June 2, 2024

I tried with "-dgs=1 -rsy=1 -asc=1 -bsm=1 -iec=1 -jvn=1 -udv=0 -ump=0", but the result is bad: arguments in lambda is not JAD style, method parameter names is JAD style in code but not in declaration.

Code fragment decompiled by ForgeFlower with "-dgs=1 -rsy=1 -asc=1 -bsm=1 -iec=1 -jvn=1 -udv=0 -ump=0"
   public void remove(ServerPlayer var1) {
      ServerLevel serverlevel = serverplayer.getLevel();
      serverplayer.awardStat(Stats.LEAVE_GAME); // 'serverplayer' is actually 'var1'
      this.save(serverplayer);
      if (serverplayer.isPassenger()) {
         Entity entity = serverplayer.getRootVehicle();
         if (entity.hasExactlyOnePlayerPassenger()) {
            LOGGER.debug("Removing player mount");
            serverplayer.stopRiding();
            entity.getPassengersAndSelf().forEach((var0) -> var0.setRemoved(Entity.RemovalReason.UNLOADED_WITH_PLAYER));
         }
      }
      ...
   }
   ...
   protected void save(ServerPlayer var1) {
      this.playerIo.save(serverplayer);
      ServerStatsCounter serverstatscounter = this.stats.get(serverplayer.getUUID());
      if (serverstatscounter != null) {
         serverstatscounter.save();
      }

      PlayerAdvancements playeradvancements = this.advancements.get(serverplayer.getUUID());
      if (playeradvancements != null) {
         playeradvancements.save();
      }

   }

I wrote a JAD name generator that generates JAD style names and writes them to LVT. Then use ForgeFlower with "-dgs=1 -rsy=1 -asc=1 -bsm=1 -iec=1" to decompile, the result is good. (at least better than above)

Code fragment decompiled by ForgeFlower with "-dgs=1 -rsy=1 -asc=1 -bsm=1 -iec=1" and my JAD name generator
   public void remove(ServerPlayer serverplayer) {
      ServerLevel serverlevel = serverplayer.getLevel();
      serverplayer.awardStat(Stats.LEAVE_GAME);
      this.save(serverplayer);
      if (serverplayer.isPassenger()) {
         Entity entity = serverplayer.getRootVehicle();
         if (entity.hasExactlyOnePlayerPassenger()) {
            LOGGER.debug("Removing player mount");
            serverplayer.stopRiding();
            entity.getPassengersAndSelf().forEach((entity) -> entity.setRemoved(Entity.RemovalReason.UNLOADED_WITH_PLAYER));
         }
      }
      ...
   }
   ...
   protected void save(ServerPlayer serverplayer) {
      this.playerIo.save(serverplayer);
      ServerStatsCounter serverstatscounter = this.stats.get(serverplayer.getUUID());
      if (serverstatscounter != null) {
         serverstatscounter.save();
      }

      PlayerAdvancements playeradvancements = this.advancements.get(serverplayer.getUUID());
      if (playeradvancements != null) {
         playeradvancements.save();
      }

   }

from forgeflower.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.