Giter Club home page Giter Club logo

Comments (2)

ntompson avatar ntompson commented on June 18, 2024

Hi @PhillyGilly, that comment at line 49 about the NeoStats not having an off mode is mine. Technically it is true: standby just applies an alternative set point (the frost point) and continues to operate as a normal functioning thermostat. Thinking about the climate platform after its rearchitecture a few months back, standby could be implemented as a preset, which is what my PR did a while back.

Since then, I see that the implementation has been changed such that standby is translated to an hvac_mode, specifically HVAC_MODE_OFF, and I think it is better for it. It's more logical and fits better with how the standard Lovelace cards work. The nice thing is that the frost point gets change if the temperature is adjusted while the NeoStat is HVAC_MODE_OFF, which was the only real reason for my previous implementation of standby as a preset.

So I think the current implementation is optimal.

To your suggestion, I get where you are coming from, but I think it would be an unfortunate mix of concerns between platform and GUI behaviour. The NeoStat alternating between heating and idle should not cause the preset to change. It should be relatively easy to achieve what you are looking for with some custom styling in Lovelace.

Oh, and the comment at line 49 really should be removed - it's not relevant anymore.

from heatmiser-for-home-assistant.

PhillyGilly avatar PhillyGilly commented on June 18, 2024

OK. I can see that using orange/grey instead of state=heat/state=off may have avoided heat/heating confusion but made the whole less clear. So the four possible permutations of operation with my "PRESET" names are:
off/idle => AWAY
off/heating=> ECO
heat/idle => COMFORT
heat/heating => BOOST
I'll drop the PRESET idea and work on my custom styling with the first task being to get the neostat HW to change colour or icon on attribute hvac_action rather than state.

from heatmiser-for-home-assistant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.