Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

Styles In Second 'STYLE' Tag Are Not Applied Correctly about premailer.net HOT 3 CLOSED

milkshakesoftware commented on June 16, 2024

Styles In Second 'STYLE' Tag Are Not Applied Correctly

from premailer.net.

Comments (3)

martinnormark commented on June 16, 2024

Aha - makes sense.

Maybe it's better to gather all styles into a dictionary grouped by selector, and then run them through once to apply the styles.

Would make it easy to implement #8 by extending the code that finds style blocks to perform a download of the linked styles.

—
Sent from Mailbox for iPhone

On Sun, Nov 10, 2013 at 12:57 PM, Rob Cooper [email protected]
wrote:

Hey @martinnormark - been doing some more testing of this and come across another issue (may have been caused by me in the last update 😊 - I've not checked).
When we ensure that existing in-line styles are honoured, we never able to apply styles from a second style tag, since we've already in-lined those from the first.

Failing Test
[TestMethod]
public void MoveCssInline_CssWithHigherSpecificityInSeparateStyleTag_AppliesMoreSpecificCss()
{
  string input = "<html><head><style type=\"text/css\">.target { width: 42px; }</style><style type=\"text/css\">.outer .inner .target { width: 1337px; }</style></head><body><div class=\"outer\"><div class=\"inner\"><div class=\"target\">test</div></div></div></body></html>";
  string premailedOutput = sut.MoveCssInline(input, false);
  Assert.IsTrue(premailedOutput.Contains("style=\"width: 1337px;\""));
}
I'm already working on the fix.

Reply to this email directly or view it on GitHub:
#22

from premailer.net.

robcthegeek commented on June 16, 2024

Hey @martinnormark - I've got this all green now, but I will refactor things a little more to pave the way for #8 (currently I'm still just iterating through all the style elements and using their InnerHtml as the basis for the style source.

I'll spin up a pull request so you can take a peek if interested, but hold fire on the merge 😄

from premailer.net.

martinnormark commented on June 16, 2024

Awesome 👍

—
Sent from Mailbox for iPhone

On Sun, Nov 10, 2013 at 2:16 PM, Rob Cooper [email protected]
wrote:

Hey @martinnormark - I've got this all green now, but I will refactor things a little more to pave the way for #8 (currently I'm still just iterating through all the style elements and using their InnerHtml as the basis for the style source.

I'll spin up a pull request so you can take a peek if interested, but hold fire on the merge 😄

Reply to this email directly or view it on GitHub:
#22 (comment)

from premailer.net.

Recommend Projects