ENH Avoid mem build-up in default log storage about rocketry HOT 4 OPEN

Thanks for your reaction! I'm glad my suggestion resonated with you.

As for the default limit, yes, 1000 log entries seems reasonable. It means that Rocketry's default mem requirement for a task that doesn't produce any logs by itself is capped at around 6.5 MB, which seems ok.

Let me know if you'd like some help with it in case you decide to go forward with an implementation.

from rocketry.

A bit background: The rational for the default logging is that it's easy to prototype and get started with Rocketry. Wasn't meant for production and the assumption was there would be some thousand records max in generic cases.

But I think you have a very valid point: there should be a hard limit by default and I think your proposal would be the way to go. I'm thinking maybe the limit could be like 1000 or so.

Thanks for the idea and I really appreciate the time you spent on investigating the issue and the solutions. I think there was another similar issue but due to lack of elaboration there I didn't get the grip on the whole issue from that.

from rocketry.

I'll do!

I'm currently working on adding optional timezone as that seems to be quite important for quite many people. After that I either try to progress on the event system or then I focus on Red Bird issues possibly including this issue. I'll notify you then if you wish to participate (like in the discussion at least, would be great to have your opinions).

from rocketry.

Hello!
I had this issue in production and fixed it with a LimitedMemoryRepo. Also implemented a NullRepo which does not track any logs whatsoever (is this going to break anything, e.g. if query_data does nothing?)

I can push my changes to be included in Rocketry as alternative log repos to the list offered by redbird

from rocketry.