[Bug]: Formula set as ScalarReference not loaded as LoadedScalarReference at runtime about mikro-orm HOT 6 CLOSED

Closing due to realizing that the ref option was required. Was under the impression that it would have been picked up by TsMorphMetadataProvider.

from mikro-orm.

Let's keep this open, I want to review it first (probably this evening). ts-morph should pick this up, and it might be failing because you use it with the Opt type intersection. Note that your repro does not use ts-morph.

from mikro-orm.

Yes, I saw that before I closed the issue. Required a bit of refactoring for it to work. It has now been added.

from mikro-orm.

Yeah, this is surely something to fix, it's about the Opt type intersection. Note that in your repro you test whether the value is true - it never will be the value itself with the Ref wrapper, it is always the Reference class (in this case ScalarReference), which wraps the value.

from mikro-orm.

So the problem here is that the TS compiler API returns the type for hasBarPost as any for some reason. If you use hasBarPost!: Opt<Ref<boolean>> it does work fine though.

edit: Damn, I again forget that the compiler API likes to give any in the ORM test suite while it works outside of it. So the type name actually resolves to (import("/Users/adamek/htdocs/mikro-orm/reproduction/node_modules/@mikro-orm/sqlite/index").ScalarReference<false> | import("/Users/adamek/htdocs/mikro-orm/reproduction/node_modules/@mikro-orm/sqlite/index").ScalarReference<true>) & { [__optional]?: 1 | undefined; }, and we fail to process that properly. Uh and why the hell it expands boolean to true | false.

from mikro-orm.

Wow, what a simple fix for such a weird issue haha

from mikro-orm.