Comments (9)
Found a few mins in-between :)
thank you so much. You too!
Added your expected.xml
as new testcase here: https://github.com/mikepenz/action-junit-report/runs/4626213715?check_suite_focus=true
the line number is properly used.
You can see the test case + PR here: #464
from action-junit-report.
The best would be if it could output the line similar to this xunit report: https://github.com/mikepenz/action-junit-report/blob/main/test_results/xunit/report.xml#L4 So it will be the clearest for the action to identify line number.
If it is provided in a different format, you can see the regex logic here which would try to parse uncover the line number: https://github.com/mikepenz/action-junit-report/blob/main/src/testParser.ts#L49-L55
from action-junit-report.
Thanks @mikepenz I'll first take a look at my output to see how i can improve it, and if that's not workable i'll ping you here about modifying the actions' parser
from action-junit-report.
the file
and line
attrs aren't mentioned in IBM's junit xml schema can you refer me to a spec doc that includes them?
from action-junit-report.
@bennypowers yes, that's correct. I couldn't find an official spec either for it to be included.
But based on different report formats having it like this proofed to be the most consistent and secure way to get the line number.
This was contributed via this format shown here in form of a xunit test report: https://github.com/mikepenz/action-junit-report/blob/main/test_results/xunit/report.xml#L4
We surely can also go the more tricky path to refine the parser. For that the easiest would be to run the tests locally and pass in the sample test exports from your reporter.
Generally always expanding our test cases with different report formats to keep sure all of them are properly working :)
from action-junit-report.
Great. Please take a look at the expected.xml
files in modernweb-dev/web#1824. If those already work with the action, we're ready to go
from action-junit-report.
I'll probably not be able to come to that today due to the holidays, but I'll try to have a look in the next few days. Hope that's early enough?
Thank you very much.
from action-junit-report.
Of course, it's no rush. Enjoy your holiday
from action-junit-report.
Thank you so much for the interest
from action-junit-report.
Related Issues (20)
- Doesn't include errors HOT 3
- Annotation truncates failure output/callstack HOT 6
- Skipping all Annotations HOT 14
- Support ESLint or Jest junit reports HOT 6
- Different line number representation (xunit) HOT 3
- Weird behavior with multiple `report_paths` and failures not being processed HOT 4
- Test report stopped working without change HOT 8
- require_tests flag is not working HOT 5
- Editor points out that github_token is required HOT 1
- Skipped tests are show as passed when included_passed set to true HOT 3
- Test failures not correctly recognized HOT 8
- action using deprecate 'set-output' command HOT 2
- Documentation for Maven Surefire HOT 2
- Out of memory error on large project HOT 14
- Failed tests are not shown in Annotations HOT 9
- Check Run Not Created when update_check: true HOT 2
- act error: Error: The runs.using key in action.yml must be one of: [composite docker node12 node16], got node20 HOT 4
- Invalid character entity when using with dastardly HOT 6
- Error: Converting circular structure to JSON HOT 9
- Option to explicitly fail check run HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-junit-report.