Giter Club home page Giter Club logo

Comments (9)

mikepenz avatar mikepenz commented on May 30, 2024 1

Found a few mins in-between :)

thank you so much. You too!

Added your expected.xml as new testcase here: https://github.com/mikepenz/action-junit-report/runs/4626213715?check_suite_focus=true

the line number is properly used.
You can see the test case + PR here: #464

https://github.com/mikepenz/action-junit-report/pull/464/files#diff-7e8670dee8014834b8a492f48380862706e856032dd2d978ef91cd5ad2103fe2R469-R483

from action-junit-report.

mikepenz avatar mikepenz commented on May 30, 2024

The best would be if it could output the line similar to this xunit report: https://github.com/mikepenz/action-junit-report/blob/main/test_results/xunit/report.xml#L4 So it will be the clearest for the action to identify line number.

If it is provided in a different format, you can see the regex logic here which would try to parse uncover the line number: https://github.com/mikepenz/action-junit-report/blob/main/src/testParser.ts#L49-L55

from action-junit-report.

bennypowers avatar bennypowers commented on May 30, 2024

Thanks @mikepenz I'll first take a look at my output to see how i can improve it, and if that's not workable i'll ping you here about modifying the actions' parser

from action-junit-report.

bennypowers avatar bennypowers commented on May 30, 2024

the file and line attrs aren't mentioned in IBM's junit xml schema can you refer me to a spec doc that includes them?

from action-junit-report.

mikepenz avatar mikepenz commented on May 30, 2024

@bennypowers yes, that's correct. I couldn't find an official spec either for it to be included.

But based on different report formats having it like this proofed to be the most consistent and secure way to get the line number.
This was contributed via this format shown here in form of a xunit test report: https://github.com/mikepenz/action-junit-report/blob/main/test_results/xunit/report.xml#L4

We surely can also go the more tricky path to refine the parser. For that the easiest would be to run the tests locally and pass in the sample test exports from your reporter.

Generally always expanding our test cases with different report formats to keep sure all of them are properly working :)

from action-junit-report.

bennypowers avatar bennypowers commented on May 30, 2024

Great. Please take a look at the expected.xml files in modernweb-dev/web#1824. If those already work with the action, we're ready to go

from action-junit-report.

mikepenz avatar mikepenz commented on May 30, 2024

I'll probably not be able to come to that today due to the holidays, but I'll try to have a look in the next few days. Hope that's early enough?

Thank you very much.

from action-junit-report.

bennypowers avatar bennypowers commented on May 30, 2024

Of course, it's no rush. Enjoy your holiday

from action-junit-report.

bennypowers avatar bennypowers commented on May 30, 2024

Thank you so much for the interest

from action-junit-report.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.