failed tests consist of the test name 2 times about action-junit-report HOT 6 CLOSED

Thank you for the report. There will be a small improvement to the name discovery: #125

By default the suite is not included in the name, for that please specify the suite_regex

from action-junit-report.

I have added suite_regex: '*' and now the reported test names look like:

positive_arguments_must_produce_expected_result.factorial/positive_arguments_must_produce_expected_result

See https://github.com/cppfw/tst/runs/2362134146?check_suite_focus=true

So, the test name positive_arguments_must_produce_expected_result still appears two times.

I'd expect it to look like this:

factorial.positive_arguments_must_produce_expected_result

from action-junit-report.

@igagis this happens here: https://github.com/mikepenz/action-junit-report/blob/main/src/testParser.ts#L191-L194

from action-junit-report.

What could be done is to add another condition to compare the retrieved filename and testname and if they are equal to not retain both

from action-junit-report.

Ok, so what is the intention of the code?

Is it so that in case we don't have suite (suiteName is empty), then instead of the suite name we use file name?

Then, why does in my case the pos.fileName have the same value as testcase._attributes.name?

Should the code be like this?

const title = suiteName
          ? `${suiteName}.${testcase._attributes.name}`
          : `${pos.fileName}.${testcase._attributes.name}`

from action-junit-report.

It is almost perfect now: https://github.com/cppfw/tst/runs/2400946865?check_suite_focus=true

Although, a small thing still can be improved, I have already commented on that in the PR, but I'll repeat here:

I think that dot is a bad delimiter for file and suite names, because file name can have dots itself. It is better to use slash to delimit file and suite names and dot to delimit suite and test names

from action-junit-report.