Giter Club home page Giter Club logo

Comments (10)

taylorfinnell avatar taylorfinnell commented on August 24, 2024

I think the latest update broke the PacketEntity parsing. Specifically I think it is this line in the official parser https://github.com/csgo-data/demoinfogo-mirror/blob/2c8134c474fe7f3e02688b30249fe3cdc107ebc1/demofilepropdecode.cpp#L62 that is not implemented correctly in jsgo.

from jsgo.

evilnes avatar evilnes commented on August 24, 2024

The feedback node gives me is

   } while (b & 0x80);
              ^
TypeError: undefined is not a function

which makes me guess there's static location being used somewhere, that has been offset by the recent addition of several new tables and variables.

from jsgo.

moritzuehling avatar moritzuehling commented on August 24, 2024

https://github.com/csgo-data/demoinfogo-mirror/blob/2c8134c474fe7f3e02688b30249fe3cdc107ebc1/demofilepropdecode.cpp#L51

This line also gives problems.

The other method looks like it would give wrong results, but not like it would break the parser. Have you had a look at my pull-request #9 ? What does it fix? What doesn't work?

from jsgo.

 avatar commented on August 24, 2024

Any fix?

from jsgo.

moritzuehling avatar moritzuehling commented on August 24, 2024

@nahtnam -have you tried #9?

from jsgo.

HarasimowiczKamil avatar HarasimowiczKamil commented on August 24, 2024

@moritzuehling I tried this does not solve all the problems.

from jsgo.

moritzuehling avatar moritzuehling commented on August 24, 2024

@HarasimowiczKamil What doesn't it solve? Sorry, I have no node-environment set up.

from jsgo.

fredricbohlin avatar fredricbohlin commented on August 24, 2024

@moritzuehling I still get "cant find entity 3" etc with newer demos.

from jsgo.

itotallyrock avatar itotallyrock commented on August 24, 2024

Hope this gets fixed/updated/pr'd I'm really interested in using this, but I'm too scared to start if there are too many issues with it being outdated.

from jsgo.

saul avatar saul commented on August 24, 2024

If you're looking to parser newer demos, take a look at my saul/demofile repo.

from jsgo.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.