Giter Club home page Giter Club logo

Comments (17)

mikebronner avatar mikebronner commented on May 26, 2024

Thanks for the heads up on #1. Will update documentation shortly.

For #2: my guess is that this has to do with the implementation in the controller or the view. Could you paste the source for both? I will be happy to take a look at it. :)

Regarding 3: this is correct for a majority of cases. However, this is one case where using the string identifiers is actually more efficient in the backend determination of access rights. (At least it was prior to upgrading to Laravel's Authorization functionality. This package has been around in one form or another since late 2014.) I will certainly re-evaluate the usage of INT vs STRING id's going forward.

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

For #2 - not using any custom controller or view. I am attempting to navigate to your "roles" route @ /genealabs/laravel-governor/roles. From the install instructions, it appears that these were navigable out of the box once collision-checking was done.

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

Ah, gotcha ... taking a look now.

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

Could you take a look at your permissions table and make sure it is populated? I'm wondering if a permission isn't missing. You should see an entry for SuperAdmin with entity role, all 5 actions, and ownership set to any on all of them.

It appears you ran the db:seed command, since your role is set ... wondering if something was amiss with the permissions.

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

Sure seems like they are all there. Image attached of Permissions table
contents.

[image: Inline image 1]

On Tue, Sep 29, 2015 at 1:55 PM, Mike Bronner [email protected]
wrote:

Could you take a look at your permissions table and make sure it is
populated? I'm wondering if a permission isn't missing. You should see an
entry for SuperAdmin with entity role, all 5 actions, and ownership set
to any on all of them.


Reply to this email directly or view it on GitHub
#8 (comment)
.

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

Could you post your project to a temporary repo I could have a look at? I'd like to see if I can replicate the issue on my machine.

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

I can't get it to github (work proxy just refuses to let me there) but I can get it on bitbucket. You use them? Or I can put it up at github @ home tonight. Which would you prefer?

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

Bitbucket is great :)

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

Okee dokie. :)

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

Here you go.

https://bitbucket.org/landjea/smarch/overview

Remember, I have some dd() in place on the welcome page and am using a
quick simple layout for auth login/registration.

On Tue, Sep 29, 2015 at 2:23 PM, Mike Bronner [email protected]
wrote:

Bitbucket is great :)


Reply to this email directly or view it on GitHub
#8 (comment)
.

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

And the .env data is there because ...garbage info. It was a brand new
clean install so I didn't put any security on it yet. :) (and probably wouldn't...I made it simply to test your package out - so far it seems to work very well, btw, with little effort. Can't wait to try the full product. 😄)

On Tue, Sep 29, 2015 at 2:31 PM, Jean-Guy Landriault <
[email protected]> wrote:

Here you go.

https://bitbucket.org/landjea/smarch/overview

Remember, I have some dd() in place on the welcome page and am using a
quick simple layout for auth login/registration.

On Tue, Sep 29, 2015 at 2:23 PM, Mike Bronner [email protected]
wrote:

Bitbucket is great :)


Reply to this email directly or view it on GitHub
#8 (comment)
.

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

awesome, thanks :) give me a bit to test this, will get back with you later today

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

@landjea I took a look at your project. The one thing that stuck out to me is that you are pulling version 0.1.0 of governor, and not ^0.1.0 or ~0.1.0.
Update your composer.json to include governor like this:

        "genealabs/laravel-governor": "~0.1.0",

After that and running composer update things seemed to work. :) Let me know if that was it.

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

Side-note: adding "laravelcollective/html" package to dependencies, should be available this afternoon.

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

I will add that to composer as soon as I get a chance, but it's weird as I copy/pasted it from the install instructions into the command line. Weird. I will let you know what happens. Thanks.

from laravel-governor.

mikebronner avatar mikebronner commented on May 26, 2024

I wonder if the pasting escaped the string, and omitted the special character? Indeed, odd. Please re-open if this issue is not resolved (closing for now). :)

from laravel-governor.

landjea avatar landjea commented on May 26, 2024

I wonder if the pasting escaped the string, and omitted the special character?

I just did another copy/paste and cancelled the batch job right after the composer.json was updated and that is precisely what happened.

Update your composer.json to include governor like this:
"genealabs/laravel-governor": "~0.1.0",

👍 That seemed to work to view the pages. Haven't tried adding/editing or anything yet.

  • Removing genealabs/laravel-governor (0.1.0)
  • Installing genealabs/laravel-governor (0.1.8)

from laravel-governor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.