Comments (3)
Hm well I foolishly assumed that sigterm is handled nicely by rust by default, i.e. that it runs stuff like Drop
impls and then exits. But apparently it does not run Drop
impls but just exits right away. So I guess you'll either want to expose a feature flag that makes inquire set up a signal handler, or expose a function that needs to actively be called by the user of the library that will then register the signal handler.
do you have any ideas in mind? or better yet, references on how other libs solve this issue?
I think tokio does it quite nicely - they seem to register some form of signal handler that just stores the received signals for the application to process. At least thats how I interpret their documentation: https://docs.rs/tokio/latest/tokio/signal/index.html. The best way would probably be to have something like this as part of std so that all applications and libraries share that api instead of doing it their way, but I guess that's not a reality right now.
from inquire.
- OS: I use Arch btw
- Browser: tf?????
- Version: 0.6.2
lol, I guess I never paid attention to the bug report template
handling sigterm is a tricky thing in and of itself, and I honestly have no idea on which role inquire should take, being a library
do you have any ideas in mind? or better yet, references on how other libs solve this issue?
one of the options would be to add signal handling behind a feature, and those interested in it can opt-in on the additional dependency, but then again, tricky :)
from inquire.
Yeah, one thing I've realized with this crate is there are two conflicting goals here, either make it simple and lean or a highly customizable thing that tries to support all scenarios.
Adding a signal handler is more of the latter, and I have been seriously wondering if inquire is accumulating a lot of bloat (e.g. see the Text prompt), and is missing the initial goal of simple prompts
From my own experience, cli apps breaking on unexpected events (resizing, signals) is often the norm, so I'm wondering how much a new feature to handle sigterm would actually be used. Because then I'll have to start adding some inter thread communication, change some lifecycle things, etc
from inquire.
Related Issues (20)
- Release HOT 1
- Use tty instead of stdin HOT 1
- with_starting_cursor does not apply HOT 2
- Fully support piped inputs in parallel with interactive inputs.
- Prompt crashes if program is run with crossterm+piped input+macos
- Add code coverage metrics to get a better idea of test coverage
- inquire derive and attribute macro HOT 3
- Show proper error message for CustomType prompt HOT 1
- Alt+{left, right, backspace} support HOT 3
- DateSelect default help message incorrect ? HOT 2
- Support for up-arrow previous prompt history, and control-keys HOT 2
- Render issue using the `console` backend HOT 2
- Inquire forgets to add newlines in 0.7.1 HOT 5
- "external_print" Functionality
- Make Scrolling More Obvious (Customizable maybe?) HOT 1
- MultiSelect list doesn't show after filter is cleared on selection HOT 1
- Suppressing static lifetimes from Text (and other modules ?) HOT 1
- typo in README for termion link
- Password prompt with redirected `stdout`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inquire.