Execute precommit scripts right before the actual commit about mversion HOT 6 CLOSED

Good suggestion. I've been thinking of this as well! Fixed now. Would be great if you could try it out and give feedback!

from mversion.

Wow, that was quick! Thank you very much.

I just saw something that could cause problems in the current implementation. All executions of hook scripts are asynchronous and the process waits for them to finish, except when executing the precommit scripts. In that case there's no callback and the commit is done right after the script execution, what may cause the commit to be done before the precommit scripts.

I'll try it out next monday.

from mversion.

Yeah, I implemented support for that when doing #24 : 53a55e3

That will wait for pre-commit to wait before doing commit.

from mversion.

Good work. Thanks!

from mversion.

It worked great! I created a test project with a npm script to call mversion. In the precommit script I did the build (just copy src/index.js to dist/index.js) add the results to the index and let mversion do the commit. The dist directory was ignored in git so that was the only commit where the contents of dist where actually versioned, so now I have what I wanted.

When do you expect to release a new version to npm?

from mversion.

I'd just like someone other than me to verify #24, and I'll do a minor release.

from mversion.