Exception thrown if `remove` action not specified about ember-cli-selectize HOT 8 CLOSED

What template did you use that generates that error?

from ember-cli-selectize.

{{ember-selectize
  content=content
  selection=selection
  optionValuePath='email'
  optionLabelPath='fullName'
  multiple=true
  openOnFocus=false
  closeAfterSelect=true
  itemFunction=itemFunction
  optionFunction=optionFunction
  create='onCreate'
  createFilter=createFilter}}

ember-cli-selectize 0.2.0

from ember-cli-selectize.

Damn, remove is a method of Ember.Component: http://emberjs.com/api/classes/Ember.Component.html#method_remove

Any suggestions for a new name?

A possibility is to change actions to the past tense:

• created
• selected
• added
• removed
• typed

/cc @sandstrom

from ember-cli-selectize.

Would it be clearer if all the method/action names referred to item or option. e.g. itemRemoved?

from ember-cli-selectize.

I don't have a strong opinion on this, but I'd try to align with other ember components. add-item select-item etc. would be fairly close to http://emberjs.com/api/classes/Ember.Handlebars.helpers.html#toc_actions

Perhaps type could be update-query or similar. Type sounds almost like a low-level key-press, but I guess it's really sort of like a 'change' event on the input.

from ember-cli-selectize.

type also sounds like the "type" of a class.
From the examples, I think it is clear that the names should be snake-cased. So anything camelCased is ruled out.
The item suffix makes this less likely to collide with existing and future properties/methods.
I think we should stick with {action}-{subject of the action}.

I prefer filter to query because we may not be dealing with a query. Also, selectize docs call this action "filtering options", hence filter:

onType(str) Invoked when the user types while filtering options.

We end up with:

• add-item
• remove-item
• select-item
• create-item
• update-filter

I like this, and all of them have a decent explanation. Enough of overthinking for me. 😄

from ember-cli-selectize.

Updated to 0.3.0 since this is a breaking change.
Solved.

from ember-cli-selectize.

Awesome! 🎆

from ember-cli-selectize.