Giter Club home page Giter Club logo

Comments (9)

mifi avatar mifi commented on May 18, 2024 3

Yes we can use ffmpeg concat and output to separate files. Just need to figure out what to do with audio in transitions. I think cross-fade is the right way. Basically need to implement a similar loop to the audio data as the video loop. but instead of gl-transition, need to use a simple mathematical operation between in and out audio.

As a simple first version we could just concat all audio files (but need to cut off transition.duration seconds off of the end of every audio clip), and need to provide silent audio when video clip has no audio, or there is no video layers in a clip.

from editly.

mifi avatar mifi commented on May 18, 2024 2

Yea, something like that. I just need to implement concatenation (and maybe fading) between videos audio clips too. It's not super trivial but it should be doable.

from editly.

chapmanjacobd avatar chapmanjacobd commented on May 18, 2024 1

https://stackoverflow.com/questions/32155105/crossfading-html5-audio-logic

we can actually do audio crossfade inside of ffmpeg

https://stackoverflow.com/questions/47437050/crossfading-between-two-audio-files-with-ffmpeg

also check out: #30 (comment) I updated this interface to make more sense. let me know what you think

from editly.

SurinameClubcard avatar SurinameClubcard commented on May 18, 2024 1

I would love to see this feature added. I just merged a couple of videos only to find out afterwards that the original audio of the clips was removed. Had to use OpenShot again to do the merging. Declarative is sooooo much nicer... :-)

from editly.

mifi avatar mifi commented on May 18, 2024 1

This is now implemented, but without cross fade yet. 0.5.0
You must use the flag --keep-source-audio or keepSourceAudio: true. See readme.

from editly.

chapmanjacobd avatar chapmanjacobd commented on May 18, 2024

maybe the default can be to take only video from the source file but if someone wanted the audio from the clips by default then they could do this:

edit: I made some improvements on this interface in: #30

from editly.

chapmanjacobd avatar chapmanjacobd commented on May 18, 2024

I was just playing around with concat last night. not sure how helpful this is:

https://gist.github.com/chapmanjacobd/7b6849c68dc78eb7679c7c639c64b9ae

a fading option would be awesome!

from editly.

mifi avatar mifi commented on May 18, 2024

Yea something like that. Problem is that if there is 1 too many video frames or one missing, or if audio or video duration is wrong, then audio will go out of sync, especially after many clips.

from editly.

chapmanjacobd avatar chapmanjacobd commented on May 18, 2024

hmmmm what if we render audio and video under separate processes and then merge them together afterword? I think this is how youtube-dl works

edit: maybe that doesn't solve the issue exactly :/ I'm not really sure what options we have here

from editly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.