Giter Club home page Giter Club logo

Comments (11)

datvm avatar datvm commented on July 17, 2024 1

@captainbrosset thanks, sent you an email.

from devtools.

datvm avatar datvm commented on July 17, 2024 1

Hi just tested on Edge Canary 128.0.2709. Everything looks good including the code logic.

from devtools.

captainbrosset avatar captainbrosset commented on July 17, 2024

Thank you for reporting this here. I have two questions:

  1. Does the bug only appear in the DevTools Console? That is: the value appears as undefined in the Console, but the code works.
  2. Are you able to provide a full code snippet for us to try and reproduce this locally? Right now, the code is incomplete and I can't really run it locally without inventing other parts of the code, which might not be the right ones to reproduce the issue.

Thank you.

from devtools.

datvm avatar datvm commented on July 17, 2024

@captainbrosset Hi,

  1. No, the DevTool tooltip is the only place where the should-be value shows up. However, the "real" value is still undefined, making my if statement's expression false when it should be true. That is, the code doesn't perform as it should.

  2. I sent it to the person at this post privately because it's a private project. Unfortunately I am not sure what causes it and cannot make a minimal reproducible example. If you provide a private channel I will send over the file.

from devtools.

captainbrosset avatar captainbrosset commented on July 17, 2024

@datvm if you can, please send the file over as a private message either on my twitter or mastodon account, which are linked to from my github account page: https://github.com/captainbrosset/
Or send it as an email: patrickbrosset at gmail dot com.

from devtools.

captainbrosset avatar captainbrosset commented on July 17, 2024

Thank you @datvm. It took me a bit of time, but I did find a reduced test case. This has nothing to do with your specific extension code, but instead seems to be a bug with the way DevTools evaluates private properties.

Here is the reduced test case:

<!DOCTYPE html>
<script>
class Foo {
  #bar = 1;
  constructor () {
    console.log(this.#bar);
    debugger;
  }
}

new Foo();
</script>

When you run this, the console shows 1, as expected, because of the console.log statement. Also, hovering over the this.#bar expression in the Sources tool shows the right value. But, when evaluating this.#bar in the Console tool, the result is undefined. See below:

image

I was also able to verify that this worked fine in Chrome, just not in Edge.

I'll bring this up with our dev team and make sure the bug is tracked on our backlog. Thank you for filing.

from devtools.

datvm avatar datvm commented on July 17, 2024

@captainbrosset Hi, thank you for the info. Please note that in your code, the issue only happens to the printed out Console, however, in my extension code, the whole expression actually gets evaluated incorrectly. For example, I added an if statement to your code:

class Foo {
  #bar = 1;
  constructor () {
    console.log(this.#bar);
    if (this.#bar < 2) {
    	console.log("< 2");
    }
    debugger;
  }
}

new Foo();

In the above code, the if expression is still evaluated correctly and < 2 is printed out even though this.#bar is printed out as undefined. In my extension code, the whole if statement is skipped due to undefined being falsy.

from devtools.

captainbrosset avatar captainbrosset commented on July 17, 2024

That is very surprising. If there's indeed an issue with the running code (whether DevTools is opened or not), then that is a different bug with the V8 scripting engine. What's surprising is that we use the exact same as Chrome does. So I don't expect there to be any differences.

Note that the DevTools bug (undefined showing up in the Console) is being investigated by our dev team, and they've identified the root cause.

I suggest waiting for a fix to make it to the next Edge Canary, and then test again to see if your issue goes away.

from devtools.

datvm avatar datvm commented on July 17, 2024

@captainbrosset Maybe an issue when the method is async? As for my extension, the code in question is this:

  if (now - this.#lastDownload < addDelay) {
      await sleepAsync(now - this.#lastDownload);
  }

In Edge, my tasks all ran at the same time without delay (that's why I used DevTools to inspect the issue to begin with). I am 90% sure the issue happens without DevTools being opened.

In Chrome, the tasks are correctly delayed.

from devtools.

captainbrosset avatar captainbrosset commented on July 17, 2024

@datvm would you have time to test something please?
Our dev team tells me they've addressed the bug where the value appears as undefined in the Console.
So, if you have some time, please make sure you have Microsoft Edge Canary 128.0.2706.0 (or later) and test your scenario again.
I'm curious to learn how it impacts your issue.

from devtools.

captainbrosset avatar captainbrosset commented on July 17, 2024

Great to hear. Thanks for testing. Closing this issue now.

from devtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.