Giter Club home page Giter Club logo

Comments (7)

nathpete-msft avatar nathpete-msft commented on May 21, 2024 1

@JudahGabriel in this specific case IrfanView does provide their own hosting, they just hide it under alternate downloads:
https://www.irfanview.info/files/iview454_x64.zip

I'd recommend taking a look at where manifests other package managers like Scoop are pulling from as a reference point. That's how I found that link for IrfanView:
https://github.com/lukesampson/scoop-extras/blob/master/bucket/irfanview.json

from winget-pkgs.

chausner avatar chausner commented on May 21, 2024 1

@JudahGabriel in this specific case IrfanView does provide their own hosting, they just hide it under alternate downloads:
https://www.irfanview.info/files/iview454_x64.zip

Even that link is not a direct download:

iwr https://www.irfanview.info/files/iview454_x64.zip

StatusCode        : 200
StatusDescription : OK
Content           : <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
                    <html><head><meta
                     content="text/html; charset=ISO-8859-1"
                     http-equiv="content-type"><title>download: files/iview454_x64.zip</title>…

They deliberately got rid of all direct links.
You only get the direct download when setting the referer appropriately:

iwr https://www.irfanview.info/files/iview454_x64.zip -Headers @{Referer="https://www.irfanview.info/files/iview454_x64.zip"}

from winget-pkgs.

lavinir avatar lavinir commented on May 21, 2024 1

You can download the file and then check for the actual download link in your browser.

Those are usually dynamically generated links that expire. I'm also looking for a good solution to this but have not found one outside of hosting it myself.

from winget-pkgs.

JudahGabriel avatar JudahGabriel commented on May 21, 2024

Follow up: I tried moving the installer to my own CDN and direct linking to that, but that doesn't work either. The PR fails saying it couldn't validate whether the installer contained malicious software. 🤷‍♀️🏳

The URL to the installer is on my CDN: https://winget.b-cdn.net/iview454_setup.exe

Exact error I'm getting:

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. Please verify the installers are not malicious. If you feel this failure is in error, please file an issue.

I do feel it's in error.

from winget-pkgs.

denelon avatar denelon commented on May 21, 2024

This has been something we've been investigating. We do SmartScreen and a few other checks to reduce the likelihood of malicious software ending up in the repository.

from winget-pkgs.

JaiganeshKumaran avatar JaiganeshKumaran commented on May 21, 2024

You can download the file and then check for the actual download link in your browser.

from winget-pkgs.

JudahGabriel avatar JudahGabriel commented on May 21, 2024

Yep, these are dynamic links that are generated with a special token. This isn't a URL that can be used in winget packages; the link won't work.

This is again why winget needs to have its own CDN mirror of installers.

from winget-pkgs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.