Giter Club home page Giter Club logo

Comments (8)

elisimpson avatar elisimpson commented on June 23, 2024 2

Issue is resolved on my end. Thanks to all!

from winget-pkgs.

mdanish-kh avatar mdanish-kh commented on June 23, 2024 1

Not sure exactly what's causing the correlation failure here, but I believe the simple solution would be to get rid of the DisplayVersion mapping and simply use PackageVersion: 4.6.6 Beta 3. DisplayVersion isn't necessarily required here since the version is also marketed as 4.6.6 (Beta 3) on the publisher's website. Also, the inclusion of DisplayVersion also means that we can't include multiple 4.6.6 Beta versions since they all would need to use the same 4.6.6 DisplayVersion, something that isn't allowed by the validation pipelines / CLI by design.

from winget-pkgs.

vikingnope avatar vikingnope commented on June 23, 2024

This contains an apps and features entry, so it should not be the case:

AppsAndFeaturesEntries:
  - DisplayName: MSI Afterburner 4.6.6 Beta 3
    DisplayVersion: 4.6.6 Beta 3

https://github.com/microsoft/winget-pkgs/blob/master/manifests/g/Guru3D/Afterburner/Beta/4.6.6/Guru3D.Afterburner.Beta.installer.yaml

from winget-pkgs.

elisimpson avatar elisimpson commented on June 23, 2024

Interesting. Something's not right though as when I do winget list I get this:

Name                                      Id                                         Version           Available Source
MSI Afterburner 4.6.6 Beta 3              Guru3D.Afterburner.Beta                    4.6.6 Beta 3      4.6.6     winget

from winget-pkgs.

vikingnope avatar vikingnope commented on June 23, 2024

@stephengillie, what would you recommend?

from winget-pkgs.

stephengillie avatar stephengillie commented on June 23, 2024

Verify:
image
image

Repro:
image

  • Ideally, the PackageVersion should be updated to match the application: v4.6.6.16381 Beta 3
  • But this doesn't cover the "upgrade always available" situation. It seems like the package manager is comparing the Registry data with the PackageVersion, and ignoring the DisplayVersion.
  • Why it's doing this and how to fix, I'm not sure. I'm guessing that maybe the DisplayVersion isn't parsing the spaces in the version number correctly - maybe adding quotes around it will help parsing?

@mdanish-kh and @Trenly, is there anything I missed here?

from winget-pkgs.

mdanish-kh avatar mdanish-kh commented on June 23, 2024

@elisimpson PR containing the mentioned changes was merged into the repo. Could you please check if you are still encountering the issue?

from winget-pkgs.

mdanish-kh avatar mdanish-kh commented on June 23, 2024

Close with reason: Issue resolved by removing DisplayVersion;

from winget-pkgs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.