Giter Club home page Giter Club logo

Comments (9)

yazeng avatar yazeng commented on May 21, 2024

Hi
I tried to repro this on my environment but failed. Everything works fine to me.
Is that a typo, missing ":" between "C\" in this "/Settings:C\MsWinSMBProtocolTest20170111_091422042536\TestSuiteConfigs\ServerLocalTestRun.testrunconfig "?
And what's the version of PTF (Protocol Test Framework) you are using?

The HTML files should be generated together with .txt files.
You check the function TestResultHandler below:
https://github.com/Microsoft/ProtocolTestFramework/blob/master/src/htmltestlogger/HtmlTestLogger.cs

Thanks,
Yan

from windowsprotocoltestsuites.

dinebhar avatar dinebhar commented on May 21, 2024

thanks,

yes there is a typo while filing bug.

i am using PTF version 1.0
Downloaded from - https://github.com/Microsoft/ProtocolTestFramework/releases/download/1.0/ProtocolTestFrameworkInstaller.msi

But i could see the same issue.

from windowsprotocoltestsuites.

dinebhar avatar dinebhar commented on May 21, 2024

The thing is the Txt files are getting generated for the test cases but not Html. I am not sure what I am missing here

from windowsprotocoltestsuites.

yazeng avatar yazeng commented on May 21, 2024

Since I cannot repro it in my machine, could you help debug it in your environment?

  1. Download code, zip is enough.
    https://github.com/Microsoft/ProtocolTestFramework

  2. Unzip the file in your machine.

  3. Open "ptf.sln" in src folder by Visual Studio.

  4. Modify the output path to the path below of HtmlTestLogger project,
    C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow\Extensions
    htmlloggeroutputpath

  5. Build the solution, then check if the new HtmlTestLogger.dll is generated in the above path:
    htmlloggergenerated

  6. Add breakpoint, see below:
    htmlloggerbreakpoint

  7. Run your command to repro

  8. When the command is running, attach the process vstest in Visual Studio.
    htmlloggerattachprocess
    htmlloggerattachvstest

The breakpoint should be hit:
htmlloggerhitbreakpoint

Then you can debug to see what happened.

Thank you in advance!
Yan

from windowsprotocoltestsuites.

dinebhar avatar dinebhar commented on May 21, 2024

Hey thank you so much. that helped a lot.

I am able to track down the issue. The method File.WriteAllText() was failing. Please check the following screenshot.

issue

I am not sure whether it is correct or not. but when it executes, the code expects the ptfconfig files must be in "Bin" directory. The code here forces me to put my *.ptfconfigs in ..\Bin\ directory.

what if someone have placed their customize config files in a different folder and updated ServerLocalTestRun.testrunconfig and command for the same.

To fix my issue i have created a bin directory to my homedir and placed all ptfconfig files to it and it worked.

I guess the code must handle the situation irrespective of test suite installation directory path, if the another path is provided.

Thank you very much for your help!

from windowsprotocoltestsuites.

dinebhar avatar dinebhar commented on May 21, 2024

for more info:
previously my command was:
cd "C:\MsWinSMBProtocolTest20170112_005936513583\TestSuiteConfigs\Logs" & "C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe" C:\MicrosoftProtocolTests\FileServer\Server-Endpoint\1.0.5000.0\Bin\MS-SMB2_ServerTestSuite.dll /TestCaseFilter:"TestCategory=Negotiate" /Settings:C:\MsWinSMBProtocolTest20170112_005936513583\TestSuiteConfigs\ServerLocalTestRun.testrunconfig /Logger:html

and ptfconfigs were at: C:\MsWinSMBProtocolTest20170112_005936513583\TestSuiteConfigs*.ptfconfig and *.testrunconfig

Then i have created a bin directory under C:\MsWinSMBProtocolTest20170112_005936513583\TestSuiteConfigs\Bin
and moved all *.ptfconfig, *.testrunconfig to the same.
New command
cd "C:\MsWinSMBProtocolTest20170112_005936513583\TestSuiteConfigs" & "C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe" C:\MicrosoftProtocolTests\FileServer\Server-Endpoint\1.0.5000.0\Bin\MS-SMB2_ServerTestSuite.dll /TestCaseFilter:"TestCategory=Negotiate" /Settings:C:\MsWinSMBProtocolTest20170112_005936513583\TestSuiteConfigs\Bin\ServerLocalTestRun.testrunconfig /Logger:html

from windowsprotocoltestsuites.

yazeng avatar yazeng commented on May 21, 2024

Well, now I can reproduce it in my machine too. :)
I agree with you, we should not expect the *.ptfconfig files are in "bin" folder.
Customized ptfconfig files are possible and we should support this scenario.
I'll file a bug and fix it later. Note, the fix will be delivered to PTF, not this repo.

Thank you very much for reporting and debugging this issue!
Yan

from windowsprotocoltestsuites.

yazeng avatar yazeng commented on May 21, 2024

The bug is fixed and changes are pushed to https://github.com/Microsoft/ProtocolTestFramework
@dinebhar , you can have a try when you have time.

from windowsprotocoltestsuites.

yazeng avatar yazeng commented on May 21, 2024

Close this issue since no update for a long time.

from windowsprotocoltestsuites.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.