Giter Club home page Giter Club logo

Comments (1)

Sergio0694 avatar Sergio0694 commented on June 2, 2024 3

Notes from API review

  • Proposed APIs look good, but let's first only add the last two overloads with explicit parameters for size and DPIs. This will make it clearer for consumers they have to manage DPI changes and size manually. We can add more later if necessary.
public sealed class CanvasSwapChain
{
    public static CanvasSwapChain CreateForWindowId(
        WindowId windowId,
        uint width,
        uint height,
        float dpi);

    public static CanvasSwapChain CreateForWindowId(
        WindowId windowId,
        uint width,
        uint height,
        float dpi,
        DirectXPixelFormat format,
        int bufferCount);
}
  • We will be adding these to both WASDK and UWP to continue keeping the two branches in sync. The namespace of WindowId is different across the two targets, but this is already a common pattern with other APIs from WASDK as well.
  • We will investigate more how best to handle runtime checks or SDK checks in general, as the necessary interop APIs for WindowId are only available on recent Windows 11 SDKs for UWP. So for now, we'll start by only adding these two APIs to the WASDK branch, and add them to the UWP one too after we figure out a strategy for this we are comfortable with.

from win2d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.