Giter Club home page Giter Club logo

Comments (7)

meganrogge avatar meganrogge commented on September 18, 2024

There's less space in the terminal, so a thinner scrollbar makes sense here IMO, @Tyriar reopen if you disagree

from vscode.

Tyriar avatar Tyriar commented on September 18, 2024

Something changed, it never used to be like this:

image

Maybe an Electron update changed what scroll bar styling is available?

from vscode.

meganrogge avatar meganrogge commented on September 18, 2024

May version is the same:

Screenshot 2024-06-19 at 7 03 16 AM

from vscode.

Tyriar avatar Tyriar commented on September 18, 2024

I think it's related to an Electron/Chrome update breaking how we styled scroll bars.

This doesn't seem easy to fix. The real fix here is to add API to xterm.js to allow the use of vscode's scrollable element.

from vscode.

s-h-a-d-o-w avatar s-h-a-d-o-w commented on September 18, 2024

There's less space in the terminal, so a thinner scrollbar makes sense here IMO

This is a significant accessibility problem. Not everybody can use a scroll wheel and grabbing a thin scroll bar can be difficult.
Thin scroll bars that can't be configured to be wider should not be acceptable for any project.

from vscode.

Tyriar avatar Tyriar commented on September 18, 2024

I disagree that it's significant, just wait until you try use one of our sashes to resize panes if you think this is hard to hit which I think has a 3px target:

Image

Especially since there are alternate options (wheel, keybindings). Also the mouse target actually seems to be wider than the slider's size.

Regardless, here's scrollbar-width: thin with decorations:

Image

And scrollbar-width: auto:

Image

It's a shame this happened at all as the decorations were perfectly sized for the old scroll bar. auto does look better now and closer to the editor so we should go with that imo. Hopefully there aren't any side effects to making this change.

from vscode.

s-h-a-d-o-w avatar s-h-a-d-o-w commented on September 18, 2024

just wait until you try use one of our sashes to resize panes if you think this is hard to hit

Resizing panes is something that I do maybe once a month. But this is why I have a voice command for resizing windows to a specific size, since I can't avoid that as well.

It's understandable that not everything can be made accessible. But scrollbars are something where people have caused unnecessary frustration for many years now.

Hopefully there aren't any side effects to making this change.

Thanks, looking forward to this fix.

from vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.