Giter Club home page Giter Club logo

Comments (4)

SuperManito avatar SuperManito commented on September 26, 2024

image
Encountered the same error on monaco-editor

from vscode.

SuperManito avatar SuperManito commented on September 26, 2024

This error has been present from monaco-editor version 0.46.0 to version 0.50.0

My web project uesed Vue and Vite not React. Both latest version. I was forced to keep using version 0.45.0. Because other versions may encounter some intolerable errors. I remember the previous stable version was 0.43.0.

I don't know how to provide feedback on these issues I encountered because submitting problems in the MonacoEditor repository requires Playground to reproduce them.

from vscode.

aeschli avatar aeschli commented on September 26, 2024

The original issue is a duplicate of #210999 (fixed now)

@SuperManito Your stack trace is at a different location: in the MenuService)

isIMenuItem(a) ? a.command.title : a.title,

There seems to be an invalid menuItem around. Reproducible steps would be very helpful.

from vscode.

lyswhut avatar lyswhut commented on September 26, 2024

The same problem occurred in monaco-editor v0.50.0.
I used vite-plugin-monaco-editor-nls to replace the language with Chinese, and the original property of a and b was undefined:
1
2
3

I patched the node_modules/monaco-editor/esm/vs/platform/actions/common/menuService.js file, and it worked again:

-const aStr = typeof a === 'string' ? a : a.original;
-const bStr = typeof b === 'string' ? b : b.original;
+const aStr = typeof a === 'string' ? a : a.original ?? a.mnemonicTitle;
+const bStr = typeof b === 'string' ? b : b.original ?? a.mnemonicTitle;

from vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.