Comments (7)
Here's a quick print out of progressive rendering timing:
Notice how the current rendered text gets disposed of more than 50ms before the next text is rendered
We likely want to render the new text and then call dispose instead
from vscode.
This seems to be because the rendered markdown result is disposed of during progressive rendering, which disposes of the link handler
Been debugging but not sure why this happens while the markdown is still visible
from vscode.
Probably same as #195949
I haven't looked into it in awhile but always suspected it's what you say- somehow related to the gap between disposing and rendering again. But, what should happen is everything gets disposed here
then immediately rerendered. Where are those logs from?
from vscode.
Just doing the render shouldn't take that long, but we could create a new DisposableStore each time, and wait to dispose the previous one until after the render.
from vscode.
Spent way too long trying to debug this. I believe what is happening is that partial rendering clears disposables here even if partsToRender
doesn't re-render the markdown (the dom node is not cleared when this happened)
Still trying to figure out the best fix as some simple ones didn't work
from vscode.
I can investigate some more, I know this part of the code has gotten a little hairy. Would like to rework it at some point so adding new content types is easier.
from vscode.
Yeah that line you point out is suspicious and I suspect it should just be deleted.
from vscode.
Related Issues (20)
- Disconnects every two minutes when ssh to the compute node of the cluster. HOT 2
- Sign In button doesn't work for Copilot HOT 4
- meu vs code ta com um bug HOT 3
- Cursor appears before decoration on empty lines
- python 3.11 environments truncated to 3.1 HOT 2
- Iteration Plan for June 2024
- Notebook Papercuts when Experimenting with LLMs
- Code will no longer run after error in terminal
- SyntaxError: Expected double-quoted property name in JSON HOT 6
- Aux window: `window.tabGroups.activeTabGroup` returns the wrong value when called from floating windows HOT 3
- terminal‘s git bash run lag HOT 3
- Terminal Ignoring First Character Of Input Via `Terminal.sendText` HOT 8
- VS Code 1.90 Using debugpy to debug python code cannot use step into to enter the dependent library HOT 5
- Needed
- When I use the custom Powershell theme, vscode terminal outputs hexadecimal gibberish, which does not occur in my jetbrains IDE. Could you consider a solution? Changing the font does not work, nor does the default monospace and Consolas. And this is a random bug, which is more gross, it may not show up for days, it may show up for days, reload WIndows is of course also random, completely random
- Add option to opt out of word wrapping files with long lines HOT 9
- When closing the application with ZenMode enabled, the Title Bar set to custom disappears (hidden) upon re-opening HOT 4
- vscode 1.90.0 generates an error when installing the plug-in using the code --install-extension ${extension} command line HOT 6
- abnormal
- Hovering over few predefined methods doesn't show method description HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode.