Recent regression: `terminalIsOpen` when clause context breaks after opening and killing a terminal about vscode HOT 6 OPEN

Using workbench.action.inspectContextKeys I found that the terminalCount flag is 1, even with no terminals open.

I also found other parameters which, for the moment, I'm using as a proxy for terminalIsOpen since they still work:

!terminalShellType && !terminalGroupCount

from vscode.

It seems that terminalIsOpen is only true if a terminal has never been opened.

thanks for the report, if your statement above is true, I'd expect terminalsOpen:false after following these steps. But for me, it is true.

1. create a terminal
2. kill it
3. create a terminal
4. value of terminalIsOpen:true

from vscode.

that keybinding works for me. i'd suggest using the command: Developer: Toggle Keyboard Shortcuts Troubleshooting to see what your issue could be

from vscode.

I think you've misunderstood. That is the opposite of what I said.

1. create a terminal
2. kill it
3. create a terminal
4. kill it
5. value of terminalIsOpen should be FALSE but it's TRUE. It remains true indefinitely until the app is closed, so that my keybinding with when=!terminalIsOpen can never trigger

Also see my comment about terminalCount being 1 even though all terminals are closed. That may be reproducible as well. I was able to reproduce it for all types of terminal I have - bash, pwsh, cmd, and a few others.

This just started after updating vscode today. I've been using these keyboard shortcuts without issue for over a year, so it's hard to see how this problem could be anything other than a vscode regression.

from vscode.

from vscode.

The bug is still closed despite the labels.

from vscode.