Giter Club home page Giter Club logo

Comments (5)

martellaj avatar martellaj commented on May 13, 2024

@weinand, thanks for porting over. I see you closed the issue, but the resolution is unclear.

from vscode-node-debug.

weinand avatar weinand commented on May 13, 2024

@martellaj my "Issue Mover" tool closed the issue in the vscode repo and moved it to the vscode-node-debug repo. But here the issue is still open and there is no resolution yet.

from vscode-node-debug.

martellaj avatar martellaj commented on May 13, 2024

Oh okay, I could've sworn it was closed here, too. Time to go get ☕. Thanks!

from vscode-node-debug.

weinand avatar weinand commented on May 13, 2024

@martellaj on a case-sensitive filesystem (e.g. on linux) your setup "foo/app.js" will not work if the file on disk actually lives in a folder "Foo". So I would call your setup at least 'dangerous' (and I was hit by this many times because I develop on a case insensitive file system but run builds on linux).

So from this perspective, I would rather try to flag the case-mismatch of the 'program' attribute as an error than make breakpoints work in this case. In addition another problem lurks around the corner: if you require('App.js')this will work on a case insensitive filesystem but again the breakpoints in 'app.js' will not be hit, because for node and the debugger the source lives in 'App.js'.

Bottom line: I will not make breakpoint matching case insensitive because it will hide potential problems. Instead I will make the initial case mismatch in your case an error because it will prevent subsequent breakpoints from being hit.

@martellaj what do you think?

from vscode-node-debug.

martellaj avatar martellaj commented on May 13, 2024

@weinand I think that's a good solution. Like I said initially, all or nothing is definitely better IMO. 👍

from vscode-node-debug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.