Make this vscode independent about vscode-lsif-extension HOT 7 OPEN

The server should actually work with other clients. Have you experienced problems with it?

from vscode-lsif-extension.

I tried using the server with another client and it worked fine, apart from it only started when the extension of the file was .js. Could this check be removed perhaps?

from vscode-lsif-extension.

@mpickering could you be a little bit more specific which check you mean.

The thing that we need to generalize is the language registration in the document selector to make this work for languages different than JS / TS

		let documentSelector: DocumentSelector = [
			{ scheme: 'file', language: 'typescript', exclusive: true } as any,
			{ scheme: 'file', language: 'javascript', exclusive: true } as any
		];

from vscode-lsif-extension.

I don't know the precise way to achieve this but it seems the server should start when there is a lsif.json file regardless of the language? So I had to modify the two places you indicated and also the activationEvents attribute.

mpickering@82f4352

from vscode-lsif-extension.

I see your point. One way to achieve this is to bundle the source code as well and use a FS provider to serve them.

from vscode-lsif-extension.

I tried a couple of changes to generalize the language registration, and it works in a proof-of-concept:

• Use workspaceContains activation event to look for an lsif.json file
• Register documentSelector for * language

Would be great to have this as other language servers add support for LSIF, and use this extension to test their changes.

The commit is available for a review here: arjunattam@4000275

from vscode-lsif-extension.

I worked on a new extension model which basically does the following:

• the dump will contain the file content as well
• the extensions servers the file content from the dump
• will add its own file schema (lsif). This has the big advantage that the extension is full language agnositic and will work wth dumps for every language (C#, TS, ...) out of the box.

I will push the changes in the next couple of days. Still need to do some cleanup

from vscode-lsif-extension.