Comments (4)
dbaeumer
commented on September 28, 2024
@bpasero this is very bad since it requires all extensions to upgrade to a new version of the language server client. Is there any kind of work around? Actually we would need to bump up our VSCode major version number since it is from that respective a breaking change.
from vscode-languageserver-node.
bpasero
commented on September 28, 2024
@dbaeumer I am not sure what you mean by "workaround"? Electron removed ATOM_SHELL_INTERNAL_RUN_AS_NODE and replaced it with (the previous already existing) ELECTRON_RUN_AS_NODE. Unless we fork Electron to bring the old environment variable back, I am not seeing a solution.
from vscode-languageserver-node.
dbaeumer
commented on September 28, 2024
Fixed by supporting both properties.
@bpasero just out of interest. Is the old one still supported by Electron?
from vscode-languageserver-node.
bpasero
commented on September 28, 2024
@dbaeumer not as far as I know, I think it got removed once Electron moved to 1.x.
from vscode-languageserver-node.
Related Issues (20)
- Document links not rendering in editor despite being correctly returned from the language server
- Interact with the running vscode Language Server HOT 1
- Is `workspace/didChangeConfiguration` must be send on LSP client when server is initialized?
- Question about the order of LSP requests and notifications (didChange and semanticTokens) HOT 6
- Stopped client can recreate its OutputChannel HOT 1
- How to handle cancelled `window/showMessageRequest` HOT 2
- FileSystemWatcher and batching HOT 7
- Allow customizing the name of the option for enabling tracing HOT 1
- vscode-languageclient/lib/common/client.js' doesn't provide an export named: 'BaseLanguageClient'
- notebook event is broken. (re-ordering cells) HOT 2
- `textDocument/definition` does not work if cursor is inside `targetSelectionRange` HOT 2
- The order of Request(completion) and Notification(did_change) seems to changed HOT 4
- Expose JSON-RPC Error Code in communication with LSP Server HOT 1
- Error: spawn EINVAL when starting the Language Server HOT 9
- ERR_SOCKET_CLOSED_BEFORE_CONNECTION could not start Language Server HOT 3
- Extra `true` in the output log when a language server disconnects
- Help me understand this error HOT 2
- File events are not sent to LSP when it's not included in the documentSelector HOT 5
- Support `isAI` property on `CodeAction` HOT 2
- Upgrade to Node 20 broke the launching of cmd files on windows HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-languageserver-node.