Comments (5)
paullinnerud
commented on May 18, 2024
The code is very messy. Some of it started on Mac decades ago, went to Windows and now back to Mac again. Inconsistent usage of tabs and spaces, etc. A clang-format file would be nice. I believe VSCode supports those or supports an extension that supports. Probably does not help those who use Visual Studio though.
from visualtruetype.
schriftgestalt
commented on May 18, 2024
I think my format file is already in HinTaks repo. I didn’t apply it, yet. So you can try and maybe edit it before we apply it to the whole source.
from visualtruetype.
HinTak
commented on May 18, 2024
Yes, the clang-format file is already in mine. I would prefer that the more obvious warnings get fixed first before large cosmetic changes though. I know I broke my own preference, changing all the mac-roman encoded comments and win 1252 comments into unicode (this is a "cosmetic" change in my book) but it is an extension of the non-ascii wide character literal fix, which is a code fix...
It was quite surprising to find non-ascii comments of the mac-roman encoded type and win 1252 type, (and in one file, both types in different sections). It certainly suggests a very long and pre-unicode history of the code base, as well as it having passed between mac and windows.
from visualtruetype.
paullinnerud
commented on May 18, 2024
Yes, VTT was originally written decades ago on the Mac. It was then ported to Windows NT and for a time both Mac and Windows versions were maintained. Then eventually the Mac was dropped when Apple had a dev platform change.
from visualtruetype.
HinTak
commented on May 18, 2024
The code currently generates a few "misleading indentation" / "dangling-else" warnings - I looked at one of them (the one in getopt.h) , and it is not entirely clear that it is mis-intented, instead of braces being mistakenly removed (when bits were being removed from full vtt to vttcompile). So that's another reason not to reindent, until those are fixed. Re-indent at the stage, if the code is actually broken because braces were mis-removed, would make it more difficult to fix.
Basically I am very against large cosmetic changes before almost all the warnings are addressed/looked at.
from visualtruetype.
Related Issues (18)
- File.cpp includes 'windows.h' HOT 1
- include test files and tests in the bundle. HOT 3
- vttcompile can't find maxp table HOT 14
- VTT legacy compile option not exposed through command line interface HOT 1
- ./vttcompile -a fails on the vttdemo.ttf on linux HOT 8
- different outcomes between vttcompile and vttshell, on vttdemo.ttf HOT 4
- illegal → invalid HOT 3
- Mac terminal port HOT 20
- Please go farther—open source the GUI. HOT 20
- Can‘t install with PIP on M1 MacBook HOT 3
- Clean up version number handling for Python extension
- Add memory interface example to pypi page.
- Test infrastructure needed HOT 1
- Automated Build HOT 3
- Composite guard feature not exposed through command line interface HOT 1
- My mingw-port branch - using mingw gcc to build, instead of visual studio. HOT 2
- linux port now on my opencompiler-port branch (the default) HOT 25
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from visualtruetype.