Giter Club home page Giter Club logo

Comments (5)

Andarist avatar Andarist commented on September 27, 2024 2

I started with a repro like this: TS playground but I managed to reduce it even further (TS playground):

const createCacheReducer = <N extends string, QR>(
  queries: Cache<N, QR>["queries"],
) => {
  const queriesMap = {} as QR;

  const initialState = {
    queries: queriesMap,
  };

  return (state = initialState) => state;
};

export type Cache<N extends string, QR> = {
  queries: {
    [QK in keyof QR]: ReturnType<typeof createCacheReducer<QR>>;
  };
};

from typescript.

Andarist avatar Andarist commented on September 27, 2024

"Probably caused by this code" is not exactly a repro case. Can you slim down ur repo to the required bits that lead to this bug?

from typescript.

gentlee avatar gentlee commented on September 27, 2024

@Andarist tried, but seems that almost all repo code is needed. Btw fixed it already by removing cycled typing, in the next commit.

Interesting that in prev commit cycles also existed but issue did not happen and everything worked, but after adding changes in that commit tsc started crashing.

from typescript.

gentlee avatar gentlee commented on September 27, 2024

FYI Overall repo is the best example of very black TS magic thats required for proper typing in some cases.

And also would be great that we don't need as in switch/case for generic literals:

// src/reducer.ts
switch (action.type) {
  case actions.updateQueryStateAndEntities.type: {
    const {
      queryKey,
      queryCacheKey,
      state: queryState,
      entityChagnes,
    } = action as ReturnType<typeof actions.updateQueryStateAndEntities> // this line should be just `} = action`

from typescript.

Andarist avatar Andarist commented on September 27, 2024

This crashes when trying to serialize the type of this createCacheReducer here:
https://github.com/gentlee/react-redux-cache/blob/ae4159b12ab02110874ffda5383ea8605b5601e7/src/types.ts#L46

FWIW, it errors because it can't find applicable signatures for this instantiation expression and it tries to report this error:

"Type '{0}' has no signatures for which the type argument list is applicable."

That leads to serializing this type in the first place.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.