Comments (4)
Simpler repro that's demonstrative
interface Foo {
bar(): void;
}
interface Baz { }
interface Foo {
bar(s?: string): void;
}
{
"seq": 0,
"type": "response",
"command": "navtree",
"request_seq": 22,
"success": true,
"body": {
"text": "<global>",
"kind": "script",
"kindModifiers": "",
"spans": [
{
"start": {
"line": 1,
"offset": 1
},
"end": {
"line": 8,
"offset": 4
}
}
],
"childItems": [
{
"text": "Baz",
"kind": "interface",
"kindModifiers": "",
"spans": [
{
"start": {
"line": 4,
"offset": 1
},
"end": {
"line": 4,
"offset": 18
}
}
],
"nameSpan": {
"start": {
"line": 4,
"offset": 11
},
"end": {
"line": 4,
"offset": 14
}
}
},
{
"text": "Foo",
"kind": "interface",
"kindModifiers": "",
"spans": [
{
"start": {
"line": 1,
"offset": 1
},
"end": {
"line": 3,
"offset": 2
}
},
{
"start": {
"line": 6,
"offset": 1
},
"end": {
"line": 8,
"offset": 2
}
}
],
"nameSpan": {
"start": {
"line": 1,
"offset": 11
},
"end": {
"line": 1,
"offset": 14
}
},
"childItems": [
{
"text": "bar",
"kind": "method",
"kindModifiers": "",
"spans": [
{
"start": {
"line": 2,
"offset": 5
},
"end": {
"line": 2,
"offset": 17
}
},
{
"start": {
"line": 7,
"offset": 5
},
"end": {
"line": 7,
"offset": 27
}
}
],
"nameSpan": {
"start": {
"line": 2,
"offset": 5
},
"end": {
"line": 2,
"offset": 8
}
}
}
]
}
]
}
}
@mjbvz We're sending back two copies of bar
that have unambiguously different parent Foo
declarations based on the span. Is it incorrect to coalesce like this? What's the expected response shape in this situation?
from typescript.
interface Foo {
bar(): void;
}
interface Baz { }
interface Foo {
bar(s?: string): void;
}
let symbols = await vscode.commands.executeCommand(
"vscode.executeDocumentSymbolProvider",
uri
);
The second "interface Foo"
selectionRange: should be {start:[5,10],end:[5,13]}, should not be {start:[5,0],end:[7,1]}
from typescript.
I think for
interface Foo {
bar(): void;
}
interface Baz { }
interface Foo {
bar(s?: string): void;
}
Showing the following:
feels like a bug on VS Code itself. But I think there is also a question on whether TypeScript should create two separate entries for Foo
.
from typescript.
This is the case with many d.ts
from typescript.
Related Issues (20)
- Some long function return expressions no longer evaluated in 5.5 HOT 3
- Generic is "`any`-like" for relational operators HOT 4
- inherit interface/type block comment HOT 2
- JSDoc: property access within static initialization block of @extends annotated class from different file
- Isolated Declarations in TS 5.5: State of the feature
- Isolated declarations quick fix suggests `boolean` return type for predicates HOT 2
- Is the "Roadmap" wiki page still maintained? HOT 3
- Typescript 5.5 is not working with yarn v4 and nodeLinker pnp, it forces switching to nodeLinker node-modules HOT 4
- update Object.values and Object.entries docs to mention they look only at own properties HOT 1
- `@import` JSDoc tag doesn't seem to account for `resolution-mode` import attribute in TS v5.5.2 HOT 1
- `/// <reference lib` is stripped out of `d.ts` file HOT 2
- HookWebpackError: Maximum call stack size exceeded in Release 5.5.2 HOT 1
- TS 5.5 type guards overly strict in some cases HOT 3
- Unresolved `any` behaves different from `any` HOT 7
- "Duplicate identifier" errors introduced in TS 5.5, if declare module is used HOT 9
- Predicate inference fails for empty object and nullish values HOT 2
- `@import`s marked as unused HOT 1
- Cannot find name 'AggregateError'.ts(2304) HOT 3
- `let` indexes using noUncheckedIndexedAccess in TS 5.5.2 HOT 6
- An unobvious point when developing a Button-or-Link component. Optional href for tag a and mandatory for Link from Next.js. [5.5.2] HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.