Comments (6)
That's very strange. I'll take a look.
from typescript.
This is a crash
This is no crash. Crash means the compiler crashes, not you receiving an error.
This changed between versions 5.3.3 and 5.3.4
You probably mean 5.4.3? There is no version 5.3.4.
Excuse my carelessness; I have made revisions.
from typescript.
This is a crash
This is no crash. Crash means the compiler crashes, not you receiving an error.
This changed between versions 5.3.3 and 5.3.4
You probably mean 5.4.3? There is no version 5.3.4.
from typescript.
crossref Will type assertions affect the type narrowing of the subsequent code?
from typescript.
The issue here appears to be inconsistent caching of union and intersection property lookups, specifically the caching logic in getUnionOrIntersectionProperty
and its handling of the skipObjectFunctionPropertyAugment
parameter. It doesn't have anything to do with narrowing.
from typescript.
I see what's happening. For various reasons we have two caches for resolved property lookups on unions and intersections, one that includes property augmentations from Object
and Function
, and one that doesn't. Logic was added in #54753 to propagate entries from the non-augmented cache to the augmented cache (see here), but that's incorrect when properties are marked with CheckFlags.Partial
. I'll put up a PR with a fix.
from typescript.
Related Issues (20)
- Modify the issue templates `bug_report.yml` and `feature_request.yml` to improve the quality of further submitted issues HOT 6
- Duplicate diagnostics HOT 2
- `const enum` references in the body of nodes with grammar errors are not inlined
- `static` methods can access `this.constructor` without complaints and compiles correctly, but a runtime error shows up HOT 13
- ModuleResolution Node16/NodeNext fails without extension starting on 5.5.0-dev.20240413 HOT 8
- Assigning a @type to an async function emits an error HOT 1
- Type predicate covariant comparison is unsound HOT 1
- Assignability to `asserts` type predicate is not checked HOT 1
- Constrained type param with `keyof` seems to have inconsistent behavior HOT 2
- Why generics are not working as expected? HOT 3
- Type guarding against BigInt using typeof not working - but using instanceof works, even though that javascript code will not work HOT 1
- Type check and Object key completion on overloaded functions with generic types defined in a class are incorrect
- Computed Void is an Expected Param where Void is not HOT 4
- Narrowing empty string or false in generic misbehaves HOT 1
- `tsc` compile `proposal-explicit-resource-management` different from `babel` and `swc` HOT 1
- After enabling noUncheckedIndexedAccess, using ++ on a default undefined does not trigger an error message. HOT 3
- C++-style `const` modifier on class members HOT 2
- Package Import is not working from neither way "CommonJS" or "Module" HOT 4
- Type guard for child not transitive parent object HOT 3
- Error when compiled JavaScript initializes static properties in a class with a hard private method (`#`) that references a static property
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.