Giter Club home page Giter Club logo

Comments (6)

ahejlsberg avatar ahejlsberg commented on April 30, 2024 2

That's very strange. I'll take a look.

from typescript.

a145789 avatar a145789 commented on April 30, 2024 1

This is a crash

This is no crash. Crash means the compiler crashes, not you receiving an error.

This changed between versions 5.3.3 and 5.3.4

You probably mean 5.4.3? There is no version 5.3.4.

Excuse my carelessness; I have made revisions.

from typescript.

MartinJohns avatar MartinJohns commented on April 30, 2024

This is a crash

This is no crash. Crash means the compiler crashes, not you receiving an error.

This changed between versions 5.3.3 and 5.3.4

You probably mean 5.4.3? There is no version 5.3.4.

from typescript.

jcalz avatar jcalz commented on April 30, 2024

crossref Will type assertions affect the type narrowing of the subsequent code?

from typescript.

ahejlsberg avatar ahejlsberg commented on April 30, 2024

The issue here appears to be inconsistent caching of union and intersection property lookups, specifically the caching logic in getUnionOrIntersectionProperty and its handling of the skipObjectFunctionPropertyAugment parameter. It doesn't have anything to do with narrowing.

from typescript.

ahejlsberg avatar ahejlsberg commented on April 30, 2024

I see what's happening. For various reasons we have two caches for resolved property lookups on unions and intersections, one that includes property augmentations from Object and Function, and one that doesn't. Logic was added in #54753 to propagate entries from the non-augmented cache to the augmented cache (see here), but that's incorrect when properties are marked with CheckFlags.Partial. I'll put up a PR with a fix.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.